RFR(S): 8221789: make reconfigure broken (jdk8u only)

[Kevin Walls]

Thanks Paul, Martin!


On 04/04/2019 15:23, Martin Buchholz wrote:
> Looks good to me!
>
> On Thu, Apr 4, 2019 at 4:05 AM Kevin Walls <kevin.walls at oracle.com 
> <mailto:kevin.walls at oracle.com>> wrote:
>
>     Hi,
>
>     I'd like to get a review of this small make change:
>
>     8221789: make reconfigure broken (jdk8u only)
>     JBS: https://bugs.openjdk.java.net/browse/JDK-8221789
>
>     hg diff pasted in below, and existing discussion:
>     https://mail.openjdk.java.net/pipermail/jdk8u-dev/2019-April/009036.html
>
>     This fixes a simple quoting error which broke argument passing in
>     "make
>     reconfigure".
>
>     Thanks
>     Kevin
>
>
>     bash-4.2$ hg diff make/Main.gmk
>     diff -r f6bc08715234 make/Main.gmk
>     --- a/make/Main.gmk     Mon Apr 01 14:28:36 2019 +0200
>     +++ b/make/Main.gmk     Thu Apr 04 03:57:24 2019 -0700
>     @@ -238,7 +238,7 @@
>               else
>                @$(ECHO) "Re-running configure using default settings"
>               endif
>     -       @( cd $(OUTPUT_ROOT) && $(BASH) $(TOPDIR)/configure
>     "$(CONFIGURE_COMMAND_LINE)" )
>     +       @( cd $(OUTPUT_ROOT) && $(BASH) $(TOPDIR)/configure
>     $(CONFIGURE_COMMAND_LINE) )
>
>       .PHONY: langtools corba jaxp jaxws hotspot jdk nashorn images
>     overlay-images install test docs
>       .PHONY: langtools-only corba-only jaxp-only jaxws-only hotspot-only
>     jdk-only nashorn-only images-only overlay-images-only install-only
>     test-only docs-only
>
>