Request for Comments: Backport of JDK-8206955: MethodHandleProxies.asInterfaceInstance does not support default methods

[Hohensee, Paul]

Pushed to jdk8u-dev. Waiting for jdk11u-fix-yes.

Paul

On 4/12/19, 6:52 PM, "Leslie Zhai" <zhaixiang at loongson.cn> wrote:

    Hi Paul,
    
    Thanks for your kind response!
    
    
    在 2019年04月12日 22:35, Hohensee, Paul 写道:
    > This looks fine, except for a nit:
    >
    > In MethodHandleProxies.java, add a blank line after " import java.util.concurrent.ConcurrentHashMap;" as in the original patch.
    
    Thanks for your review!  Updated: 
    http://cr.openjdk.java.net/~lzhai/8206955-8u/webrev.01/
    
    >
    > I see you're not a jdk8u committer, so if you like I'll sponsor and push the patch (with the extra blank line :)). I've added a jdk8u fix request to JDK-8206955.
    
    Thanks for your sponsor!
    
    >
    > This patch should also be backported to jdk11u. No need for an email for patches such as this that apply cleanly. You should be able to just tag JDK-8206955 with jdk11u-fix-request. I'll sponsor/push that too if you like.
    
    Taged :)
    
    Thanks,
    Leslie Zhai
    
    >
    > Thanks,
    >
    > Paul
    >
    > On 4/11/19, 7:57 PM, "jdk8u-dev on behalf of Leslie Zhai" <jdk8u-dev-bounces at openjdk.java.net on behalf of zhaixiang at loongson.cn> wrote:
    >
    >      Hi Andrew,
    >      
    >      I fixed the similar issue as JDK-8203699 for jdk-mips,  and I need to
    >      backport the fix for jdk-mips to jdk8-mips,  because JDK-8203699 is also
    >      reproducible after backport the fix for JDK-8206955 to jdk8-mips.
    >      
    >      在 2019年04月10日 18:07, Leslie Zhai 写道:
    >      > Hi,
    >      >
    >      > I would like to backport the fix for:
    >      
    >      Could I backport the fix?
    >      
    >      Thanks,
    >      Leslie Zhai
    >      
    >      >
    >      >
    >      > https://bugs.openjdk.java.net/browse/JDK-8206955
    >      >
    >      > To OpenJDK 8 updates dev:
    >      >
    >      > http://hg.openjdk.java.net/jdk8u/jdk8u-dev
    >      >
    >      > The fix is mostly the same as the version that was committed in 12.
    >      >
    >      > Webrev: http://cr.openjdk.java.net/~lzhai/8206955-8u/webrev.00/
    >      >
    >      > Please review it and give me some comments.
    >      >
    >      > Thanks,
    >      >
    >      > Leslie Zhai
    >      >
    >      >
    >      
    >      
    >      
    >