[8u-dev] RFR: JDK-8222975: Fix 'release' file to reflect actual repo checkin used to compile JDK

[Simon Tooke]

On 4/25/2019 12:29 AM, Andrew John Hughes wrote:
>
> On 24/04/2019 20:29, Simon Tooke wrote:
>> Hi,
>>
>> In the process of the latest CPU, I found the 'release' file differed
>> between the Linux and Windows built images, and tracked it down to the
>> use of 'hg tip' instead of 'hg id'.
>>
>> As luck would have it, this was previously reported (JDK-8031567) and
>> fixed in JDK 9. 
>>
>> Rather than backport the entire PR to jdk8u, I propose only enough to
>> fix the actual problem; replacing the calls to 'hg tip' with calls to
>> 'hg id -i'.
>>
>> Original JBS: https://bugs.openjdk.java.net/browse/JDK-8031567
>>
>> Webrev: http://cr.openjdk.java.net/~stooke/webrevs/jdk-8031567/
>>
>> I'm open to a full backport, but wanted to minimize perturbation of 8u. 
>> If this is misguided, please correct me...
>>
>> Thank you for your time,
>>
>> -Simon
>>
>>
> Given that 8031567 is an enhancement which rewrites the offending code
> altogether, I don't think a smaller, different change should really go
> in under the same ID. It will make it look like 8031567 is present in
> OpenJDK 8, but none of the actual code that is in 9+ will be there.
>
> I'd prefer a full backport of 8031567 for consistency with 9+, but the
> current webrev is fine too, as long as it is committed under its own ID.

That makes sense.  I've created a new bug entry:

Issue: https://bugs.openjdk.java.net/browse/JDK-8222975

Webrev: http://cr.openjdk.java.net/~stooke/webrevs/jdk-8222975/

-Simon