[8u-dev] RFR: JDK-8222975: Fix 'release' file to reflect actual repo checkin used to compile JDK

[Andrew John Hughes]

On 25/04/2019 17:57, Simon Tooke wrote:
> 
> On 4/25/2019 12:19 PM, Andrew John Hughes wrote:
>> On 25/04/2019 16:23, Simon Tooke wrote:
>>> On 4/25/2019 12:29 AM, Andrew John Hughes wrote:
>>>> On 24/04/2019 20:29, Simon Tooke wrote:
>>>>> Hi,
>>>>>
>>>>> In the process of the latest CPU, I found the 'release' file differed
>>>>> between the Linux and Windows built images, and tracked it down to the
>>>>> use of 'hg tip' instead of 'hg id'.
>>>>>
>>>>> As luck would have it, this was previously reported (JDK-8031567) and
>>>>> fixed in JDK 9. 
>>>>>
>>>>> Rather than backport the entire PR to jdk8u, I propose only enough to
>>>>> fix the actual problem; replacing the calls to 'hg tip' with calls to
>>>>> 'hg id -i'.
>>>>>
>>>>> Original JBS: https://bugs.openjdk.java.net/browse/JDK-8031567
>>>>>
>>>>> Webrev: http://cr.openjdk.java.net/~stooke/webrevs/jdk-8031567/
>>>>>
>>>>> I'm open to a full backport, but wanted to minimize perturbation of 8u. 
>>>>> If this is misguided, please correct me...
>>>>>
>>>>> Thank you for your time,
>>>>>
>>>>> -Simon
>>>>>
>>>>>
>>>> Given that 8031567 is an enhancement which rewrites the offending code
>>>> altogether, I don't think a smaller, different change should really go
>>>> in under the same ID. It will make it look like 8031567 is present in
>>>> OpenJDK 8, but none of the actual code that is in 9+ will be there.
>>>>
>>>> I'd prefer a full backport of 8031567 for consistency with 9+, but the
>>>> current webrev is fine too, as long as it is committed under its own ID.
>>> That makes sense.  I've created a new bug entry:
>>>
>>> Issue: https://bugs.openjdk.java.net/browse/JDK-8222975
>>>
>>> Webrev: http://cr.openjdk.java.net/~stooke/webrevs/jdk-8222975/
>>>
>>> -Simon
>>>
>>>
>> Ok, change looks good to me.
>>
>> Flag the bug with jdk8u-fix-request and I'll approve it.
>>
>> Do you have push rights or does someone need to do so on your behalf?
>>
>> Thanks,
> 
> Thanks for the review!
> 
> I've flagged the bug as requested, but unfortunately I don't yet have
> push rights.
> 
> -simon
> 
> 
> 

Approved and pushed:

https://hg.openjdk.java.net/jdk8u/jdk8u-dev/rev/84adf64edebb

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew