[Ping] Re: [8u-dev, ppc] RFR for (almost clean) backport of 8188868: PPC64: Support AES intrinsics on Big Endian

[Kazunori Ogata]

Hi Andrew,

Thank you for reviewing the webrev.

Regards,
Ogata

Andrew John Hughes <gnu.andrew at redhat.com> wrote on 2019/08/01 01:05:48:

> From: Andrew John Hughes <gnu.andrew at redhat.com>
> To: Kazunori Ogata <OGATAK at jp.ibm.com>, hotspot-compiler-
> dev at openjdk.java.net, jdk8u-dev at openjdk.java.net
> Date: 2019/08/01 01:13
> Subject: [EXTERNAL] Re: [Ping] Re: [8u-dev, ppc] RFR for (almost clean) 
> backport of 8188868: PPC64: Support AES intrinsics on Big Endian
> 
> 
> 
> On 31/07/2019 10:30, Kazunori Ogata wrote:
> > Ping.
> > 
> > May I get review for the almost clean backport?
> > 
> > Regards,
> > Ogata
> > 
> > Kazunori Ogata/Japan/IBM wrote on 2019/07/24 17:48:23:
> > 
> >> From: Kazunori Ogata/Japan/IBM
> >> To: hotspot-compiler-dev at openjdk.java.net, jdk8u-dev at openjdk.java.net
> >> Date: 2019/07/24 17:48
> >> Subject: [8u-dev,  ppc] RFR for (almost clean) backport of 8188868: 
> > PPC64:
> >> Support AES intrinsics on Big Endian
> >>
> >> Hi,
> >>
> >> May I get review for backport of 8188868: PPC64: Support AES 
intrinsics 
> > on
> >> Big Endian?
> >>
> >> The original patch itself can be applied cleanly (besides difference 
of 
> >> the source directory structure). However, one chunk failed because 
the 
> >> code just after the patched code was modified, so I manually applied 
the 
> > 
> >> chunk and renewed the patch.
> >>
> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8188868
> >> Webrev: 
> > http://cr.openjdk.java.net/~ogatak/jdk8u_aes_be/8188868/webrev.02/
> >>
> >> This backport is low risk and affects only PPC64 only. I verified 
there 
> >> was no degradation in "make test" results and SPECjbb 2015 ran fine. 
The 
> > 
> >> intrinsics added in this changeset improved max jOPS by 5% and 
critical 
> > jOPS by 4%. 
> >>
> >> Regards,
> >> Ogata
> > 
> 
> Sorry, I started looking at this yesterday, but didn't get chance to 
finish.
> 
> It looks fine to me. The stubGenerator_ppc.cpp changes were a little
> hard to follow, but comparing the patched version with the 11u version
> looked ok.
> 
> Good to go.
> -- 
> Andrew :)
> 
> Senior Free Java Software Engineer
> Red Hat, Inc. (http://www.redhat.com)
> 
> PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
> Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
> https://keybase.io/gnu_andrew
> 
> [attachment "signature.asc" deleted by Kazunori Ogata/Japan/IBM]