PING? [8u] RFR: 8135318: CMS wrong max_eden_size for check_gc_overhead_limit

[Severin Gehwolf]

On Wed, 2019-08-07 at 17:47 +0200, Aleksey Shipilev wrote:
> On 8/7/19 4:36 PM, Severin Gehwolf wrote:
> > On Tue, 2019-07-09 at 14:37 +0200, Severin Gehwolf wrote:
> > > Bug: https://bugs.openjdk.java.net/browse/JDK-8135318
> > > webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8135318/01/webrev/
> > > JDK 9 change: http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/dd0c55eac358
> 
> Backport looks good.

Thanks for the review!

> Looks like a simple fix without any bug tail. So the code in 8u would now compute eden size as
> "max_young - 2*survivor", which makes sense: eden, plus from/to survivor spaces. Before it computed
> it as "max_young - 3*survivor", which is erroneous. (It is weird DefNewGeneration::max_capacity()
> discounts survivor space size, leading to this problem...) Right?

That's my understanding. It's been there since 2007 "Initial load" :)

Thanks,
Severin