[JFR] Port Status

[Mario Torre]

Hi Andrey,

Yes, if they are part of the patch you are about to push I think it's
fine to just add the 8202835 to the ids. It's starting to be tricky to
follow any bug that that belongs to any line of code change so this is
probably the best :)

Cheers,
Mario

On Mon, Aug 12, 2019 at 3:58 PM Andrey Petushkov <andrey at azul.com> wrote:
>
> Hi guys,
>
> These changes were already part of initial JFR backport diff. My bad, for some reason I lost these two bugs in the list of changes backported.
> I believe the right way is to add 8202835 into commit message. Please confirm
>
> Andrey
>
> > On 12 Aug 2019, at 16:46, Andrew John Hughes <gnu.andrew at redhat.com> wrote:
> >
> >
> >
> > On 09/08/2019 10:49, Mario Torre wrote:
> >>
> >>
> >> On Thu, Aug 8, 2019 at 8:56 PM Andrew John Hughes <gnu.andrew at redhat.com
> >> <mailto:gnu.andrew at redhat.com>> wrote:
> >>
> >>
> >>
> >>    On 08/08/2019 11:19, Mario Torre wrote:
> >>> Hi all,
> >>>
> >>> I just updated the staging repository with the latest code from the
> >>> jdk8u repository. I also added a new label on Jira:
> >>>
> >>> jfr-jdk8u-backport
> >>>
> >>> This can be used to track down all the patches we are backporting in
> >>> the staging repository and later on into mainline 8u.
> >>>
> >>> This should make it easier to track things around.
> >>>
> >>> I think one label is enough, if we want to mark a distinction on
> >>> patches we "want" to backport as opposed to the one we "did" backport
> >>> we can add another label, i.e. jfr-jdk8u-backport-staging, but I don't
> >>> see much reason to do this, any suggestions?
> >>>
> >>> Cheers,
> >>> Mario
> >>>
> >>
> >>    One thing to consider is JDK-8202353:
> >>
> >>    https://bugs.openjdk.java.net/browse/JDK-8202353
> >>
> >>    When I backported this, I had to drop JFR code changes. Compare:
> >>
> >>    https://hg.openjdk.java.net/jdk/jdk/rev/f605c91e5219
> >>
> >>    and
> >>
> >>    https://hg.openjdk.java.net/jdk8u/jdk8u/hotspot/rev/0f2fe7d37d8c
> >>
> >>    The bug:
> >>
> >>    https://bugs.openjdk.java.net/browse/JDK-8202835
> >>
> >>    would be ideal to use to backport the remaining changes. The original
> >>    changeset used both bug IDs, but the 8u one only used 8202353.
> >>
> >>
> >> Thanks Andrew!
> >>
> >> I'll add this to the list.
> >>
> >> Cheers,
> >> Mario
> >>
> >> --
> >> Mario Torre
> >> Associate Manager, Software Engineering
> >> Red Hat GmbH <https://www.redhat.com>
> >> 9704 A60C B4BE A8B8 0F30  9205 5D7E 4952 3F65 7898
> >
> > Right. You tagged the wrong bug though. I moved it to
> >
> > https://bugs.openjdk.java.net/browse/JDK-8202835
> >
> > Thanks,
> > --
> > Andrew :)
> >
> > Senior Free Java Software Engineer
> > Red Hat, Inc. (http://www.redhat.com)
> >
> > PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
> > Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
> > https://keybase.io/gnu_andrew
>


-- 
Mario Torre
Associate Manager, Software Engineering
Red Hat GmbH <https://www.redhat.com>
9704 A60C B4BE A8B8 0F30  9205 5D7E 4952 3F65 7898