[8u] RFR (S) 8223177: Data race on JvmtiEnvBase::_tag_map in double-checked locking

[Andrew John Hughes]

On 07/08/2019 11:53, Aleksey Shipilev wrote:
> Original bug:
>   https://bugs.openjdk.java.net/browse/JDK-8223177
>   https://hg.openjdk.java.net/jdk/jdk/rev/27c8a2e0b0e5
> 
> This patch applies to 8u, but does not compile, because regular OrderAccess methods do not accept
> pointers. We need to use the *_ptr_* versions of the same methods and do casts from void*.
> 
> 8u webrev:
>   http://cr.openjdk.java.net/~shade/8223177/webrev.8u.01/
> 
> Testing: tier1
> 

Looks good to me.

The OrderAccess method change is necessary because 8u lacks JDK-8188813:
https://bugs.openjdk.java.net/browse/JDK-8188813
https://hg.openjdk.java.net/jdk10/master/rev/a1f68e415b48

You're missing "that full template experience" ;-)

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew