RFR: Backport JDK-8217359: C2 compiler triggers SIGSEGV after transformation in ConvI2LNode::Ideal

[Andrew John Hughes]

On 22/08/2019 14:59, Roman Kennke wrote:
> 
> 
> Am 22.08.19 um 15:35 schrieb Andrew John Hughes:
>>
>>
>> On 20/08/2019 23:28, Roman Kennke wrote:
>>> This backports to 8u:
>>>
>>> https://bugs.openjdk.java.net/browse/JDK-8217359
>>>
>>> The fix applies after fixing paths and putting the patch into the right
>>> place in connode.cpp instead of convertnode.cpp.
>>>
>>> Testing: passes new testcase (fails without fix), passes tier1, tier2
>>>
>>> Webrev:
>>> http://cr.openjdk.java.net/~rkennke/JDK-8217359/webrev.00/
>>>
>>> Can I please get a review?
>>>
>>> Roman
>>>
>>
>> The connode.cpp copyright header needs to be bumped in the same way as
>> convertnode.cpp's was in the original patch (currently it says 2013).
>>
>> Otherwise looks good.
> 
> Ok, thank you! I'll update this before pushing without posting another
> webrev. Waiting for maintainer approval.
> 
> Thanks,
> Roman
> 

And I'm the maintainer approving it ;-)

I'm happy to trust you to fix that without another webrev. Thumbs up.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew