[8u] 8062808: Turn on the -Wreturn-type warning

[Liu, Xin]

Thanks, Andrew. 

I saw you got review approval by Severin. How about we move forward? 
I am good if you apply your patch for JDK-8062808. Could you also take care of 'perfData.hpp'?  we missed it. 

Thanks,
--lx


On 8/30/19, 8:53 AM, "Andrew John Hughes" <gnu.andrew at redhat.com> wrote:

    
    
    On 28/08/2019 22:00, Liu, Xin wrote:
    > Hi,
    > 
    > 
    > I'd like to backport JDK-8062808.  Enabling -Wreturn-type helps us to catch undefined code.  Could you review it and update label in that issue?
    > 
    > webrev: https://cr.openjdk.java.net/~xliu/8062808/webrev/
    > 
    > 
    > It's almost a clean patch. One single difference is that original patch doesn't include perfData.hpp. It has been changed in JDK-8064811. When we backported JDK-8064811 to jdk8u, I think we drop it by mistake.
    > 
    > 
    > I have verified it using the jdk8u repo. Both fastdebug and slowdebug work as expected.
    > 
    > 
    > thanks,
    > 
    > --lx
    > 
    
    I already have a backport of this, which I intend to post once
    JDK-8141570 is in; see [0]. Doing this beforehand will break the Zero build.
    
    [0]
    https://mail.openjdk.java.net/pipermail/jdk8u-dev/2019-August/010100.html
    
    Thanks,
    -- 
    Andrew :)
    
    Senior Free Java Software Engineer
    Red Hat, Inc. (http://www.redhat.com)
    
    PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
    Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
    https://keybase.io/gnu_andrew