[8u] [1/2] RFR backport of 8223490: Optimize search algorithm for determining default time zone

Hohensee, Paul hohensee at amazon.com
Thu Dec 5 22:54:19 UTC 2019


I'll push them for you.

Paul

On 12/5/19, 1:55 PM, "jdk8u-dev on behalf of David Alvarez" <jdk8u-dev-bounces at openjdk.java.net on behalf of alvdavi at amazon.com> wrote:

    8234591 was a clean backport. Once I get the review approval for
    8223490, I'll ensure I'll add a comment when doing the jdk8u-fix-request
    so 8223490, 8231124 and 8234591 are all push together. I'll need a
    commiter to push the changes for me.
    
    For convenience, I have a copy of the 8u patch of 8234591 [1]
    
    David
    
    --
    [1] http://cr.openjdk.java.net/~alvdavi/patches/8234591.8u.00.patch
    
    On 2019-12-05 13:38, David Alvarez wrote:
    > Thanks for catching that one, being only in 11u and not in tip in flew
    > under my radar. I will backport it to 8 too.
    > 
    > David
    > 
    > On 2019-12-05 01:41, Yuri Nesterenko wrote:
    >> Hi David,
    >>
    >> could you please consider a small change from
    >>
    >> https://bugs.openjdk.java.net/browse/JDK-8234591 ? 
    >> It may be even more important for jdk8.
    >>
    >> Thanks,
    >> --yan
    >>
    >> On 05.12.2019 01:38, David Alvarez wrote:
    >>> Hi,
    >>>
    >>> I would like to request a backport of JDK-8223490.
    >>>
    >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8223490
    >>> Original: https://hg.openjdk.java.net/jdk/jdk/rev/8ee083465318
    >>> Webrev: http://cr.openjdk.java.net/~alvdavi/webrevs/8223490/webrev.8u.00/
    >>>
    >>> The patch is marked as 8u241 but not yet in openjdk8u242.
    >>>
    >>> Patch did not apply cleanly, multiple modifications were required.
    >>>
    >>> jkd8u missing JDK-8202794 [1] meant we still had the dirent64 *entry
    >>> around and references to readdir64_r. We also don't have JDK-7153347 [2]
    >>> which added multiple changes to the original findZoneInfoFile method.
    >>> Nor do we have JDK-8214077 [3] that changed statbuf to a stat64. It is
    >>> possible these are not the only ones.
    >>>
    >>> This patch will be followed up by a backport of JDK-8231124 which is a
    >>> follow up.
    >>>
    >>> I've run Tier1 and Tier2 tests, no regressions found. Additionally, I've
    >>> been able to test on an affected system, where ZoneId.systemDefault()
    >>> was returning Zulu before the patch, and UTC after.
    >>>
    >>> Thanks,
    >>>
    >>> David
    >>>
    >>> --
    >>> [1] https://bugs.openjdk.java.net/browse/JDK-8202794
    >>> [2] http://hg.openjdk.java.net/jdk10/jdk10/jdk/rev/4887534fa39b
    >>> [3] https://bugs.openjdk.java.net/browse/JDK-8214077
    >>> [4] https://bugs.openjdk.java.net/browse/JDK-8231124
    >>>
    >>>
    >>>
    >>>
    >>
    



More information about the jdk8u-dev mailing list