[8u] RFR 8134424: BlockDataInputStream.readUTFBody: size local StringBuffer with the given length

[Andrew John Hughes]

On 28/11/2019 13:43, Yuri Nesterenko wrote:
> Hi,
> 
> please take a look at this request for review for OpenJDK 8 backport of
> 8134424 [1].
> 
> Webrev is
> 
> http://cr.openjdk.java.net/~yan/8134424/webrev.0
> 
> Patch applied cleanly with jdk8 specifics: path was changed. Also,
> copyright date was set to 2019.
> 
> The patch itself was discussed in
> https://mail.openjdk.java.net/pipermail/core-libs-dev/2016-February/038684.html
> 
> Thank you!
> 
> --yan
> 
> [1] https://bugs.openjdk.java.net/browse/JDK-8134424
> 
> 

Please don't alter the copyright date. The original patch is from 2016
and the target file already has a 2018 date. By altering the copyright
date with this patch, you add a change not present in other versions of
the patch and introduce the potential for conflicts with later backports.

As is, with just path changes, this doesn't need review and can simply
be approved.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew