[8u] RFR 8208715: Conversion of milliseconds to nanoseconds in UNIXProcess contains bug

[Hohensee, Paul]

Thank you, Andrew, for your review. I've tagged 8029629 with jdk8u-fix-request: the patch applies cleanly and its patched test passes. Once 8029629 is in place, the patch for 8208715 applies cleanly and its patched test also passes, so both can be approved without further review.

Paul

On 12/4/19, 11:15 AM, "jdk8u-dev on behalf of Andrew Hughes" <jdk8u-dev-bounces at openjdk.java.net on behalf of gnu.andrew at redhat.com> wrote:

    
    
    On 29/08/2019 21:29, Guo, James wrote:
    > Hi,
    > 
    > Original bug:
    >      https://bugs.openjdk.java.net/browse/JDK-8208715
    >      https://hg.openjdk.java.net/jdk/jdk/rev/41257a58a588
    >         
    > Original patch does not apply cleanly to 8u:
    >         1. java.base/unix doesn't exist. I had to move the change of java.base/unix/classes/java/lang/ProcessImpl.java 
    > to solaris/classes/java/lang/UNIXProcess.java to make the patch work in Unix.
    >         2. Due to the conflict in test/java/lang/ProcessBuilder/Basic.java, I had to replace the testcase that checks 
    > Process.waitFor(timeout, TimeUnit.MILLISECONDS) with the one in 12u[1] and add a millisElapsedSince(long startNanoTime) method for it.
    >         
    > 8u webrev:
    >      http://cr.openjdk.java.net/~alvdavi/webrevs/8208715/webrev.8u.00/
    >         
    > Testing: x86_64 build, affected tests [2], tier1
    >         
    > Thanks,
    > James Guo
    >         
    > [1] http://hg.openjdk.java.net/jdk/jdk/file/41257a58a588/test/jdk/java/lang/ProcessBuilder/Basic.java#l2410
    > [2] https://bugs.openjdk.java.net/secure/attachment/78016/JI9056393.java
    >         
    >         
    > 
    > 
    
    Am I right in thinking that the additional test changes are from
    JDK-8029629?
    
    https://hg.openjdk.java.net/jdk/jdk/rev/8e5afc67dca87179
    
    If so, that bug should be backported first.
    
    Thanks,
    -- 
    Andrew :)
    
    Senior Free Java Software Engineer
    Red Hat, Inc. (http://www.redhat.com)
    
    PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
    Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222