[8u] RFR 8185898: setRequestProperty(key, null) results in HTTP header without colon in request

[Andrew John Hughes]

On 26/11/2019 12:46, Yuri Nesterenko wrote:
> Hi,
> 
> please review this request for a backport to 8u.
> 
> Original issue:
> 
>     https://bugs.openjdk.java.net/browse/JDK-8185898
> 
>     https://hg.openjdk.java.net/jdk/jdk/rev/0211b062843d
> 
> The patch itself applied good enough; I had to adapt the test for JDK8.
> 
> Look for webrev here:
> 
>     http://cr.openjdk.java.net/~yan/8185898/webrev.0/
> 
> Thank you!
> 
> --yan
> 
> 

It doesn't matter for this testcase, but List.of and Map.of create
unmodifiable collections, so if they are exposed outside the scope of a
single method, they should be wrapped using
Collections.unmodifiableMap/List.

Otherwise, looks ok. I assume the testcase passes with the patch?

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew