[8u] RFR 8201627: Kerberos sequence number issues

[Andrew John Hughes]

On 25/07/2019 22:51, Martin Balao wrote:
> Hi,
> 
> I'd like to request a review for the jdk8u backport of 8201627 [1]:
> 
>  *
> http://cr.openjdk.java.net/~mbalao/webrevs/8201627/8201627.webrev.00.jdk8u.jdk/
> 
> Changes that were needed to the baseline patch:
> 
>  * Copyright dates
> 
>  * Paths
> 
>  * GetPropertyAction.privilegedGetProperty receives no default value in
> jdk8u (InitSecContextToken.java)

I think there's a case here for backporting JDK-8154231 or at least
bringing over the remaining two methods for GetPropertyAction that
weren't part of JDK-8181048.

> 
>  * test/sun/security/krb5/auto/BasicProc.java (several adjustments)

What are these "several adjustments"? It looks to me like the
refactoring in JDK-8186884 needs backporting first, as this patch seems
to drag in some of those changes as well.

> 
>  * test/sun/security/krb5/auto/Basic.java (minor adjustments)
> 
> Testing:
> 
>  * No regressions found in sun/security/krb5/auto
> 
> Thanks,
> Martin.-
> 
> --
> [1] - https://bugs.openjdk.java.net/browse/JDK-8201627
> 

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew