[JFR backport] RFC: CSR for JFR backport suggests not leaving out the package-info

[Mario Torre]

Hi Marcus,

I applied your new webrev and tested and all seems to work as expected:

http://cr.openjdk.java.net/~hirt/JDK-8236074/webrev.0

The patch is approved.

Cheers,
Mario

On Tue, Dec 17, 2019 at 11:48 AM Mario Torre <neugens at redhat.com> wrote:
>
> Hi Marcus,
>
> The patch is ok, but of course the
> src/share/classes/jdk/jfr/package-info.java needs to be removed since
> we already pushed this as part of JDK-8236002. Can you please share an
> hg export so I'll apply and push for you?
>
> Cheers,
> Mario
>
> On Mon, Dec 16, 2019 at 11:20 PM Mario Torre <neugens at redhat.com> wrote:
> >
> > Hi Marcus,
> >
> > Can you please file another bug report?
> >
> > I’ll check the patch and commit in the morning.
> >
> > Cheers,
> > Mario
> >
> > On Monday, December 16, 2019, Marcus Hirt <marcus.hirt at datadoghq.com> wrote:
> >>
> >> Hi Mario,
> >>
> >> There was another one. Also adding the internal one, to make it
> >> similar to JDK 11.
> >> http://cr.openjdk.java.net/~hirt/JDK-8236002/webrev.1/
> >>
> >> Kind regards,
> >> Marcus
> >>
> >> On Mon, Dec 16, 2019 at 4:52 PM Mario Torre <neugens at redhat.com> wrote:
> >> >
> >> > Approved.
> >> >
> >> > Cheers,
> >> > Mario
> >> >
> >> > On Mon, Dec 16, 2019 at 4:40 PM Mario Torre <neugens at redhat.com> wrote:
> >> > >
> >> > > [I'm sending this on behalf of Marcus which is not on the list]
> >> > >
> >> > > Hi all,
> >> > >
> >> > > Here is the fix for the missing package info!
> >> > >
> >> > > Jira:  https://bugs.openjdk.java.net/browse/JDK-8236002
> >> > > Webrev: http://cr.openjdk.java.net/~hirt/JDK-8236002/webrev.0/
> >> > >
> >> > > Kind regards,
> >> > > Marcus
> >> > >
> >> > > --
> >> > > Mario Torre
> >> > > Associate Manager, Software Engineering
> >> > > Red Hat GmbH <https://www.redhat.com>
> >> > > 9704 A60C B4BE A8B8 0F30  9205 5D7E 4952 3F65 7898
> >> >
> >> >
> >> >
> >> > --
> >> > Mario Torre
> >> > Associate Manager, Software Engineering
> >> > Red Hat GmbH <https://www.redhat.com>
> >> > 9704 A60C B4BE A8B8 0F30  9205 5D7E 4952 3F65 7898
> >> >
> >>
> >
> >
> > --
> > Mario Torre
> > Associate Manager, Software Engineering
> > Red Hat GmbH <https://www.redhat.com><br>9704 A60C B4BE A8B8 0F30  9205 5D7E 4952 3F65 7898
>
>
>
> --
> Mario Torre
> Associate Manager, Software Engineering
> Red Hat GmbH <https://www.redhat.com>
> 9704 A60C B4BE A8B8 0F30  9205 5D7E 4952 3F65 7898



-- 
Mario Torre
Associate Manager, Software Engineering
Red Hat GmbH <https://www.redhat.com>
9704 A60C B4BE A8B8 0F30  9205 5D7E 4952 3F65 7898