[8u] 8236178: Debug build failed after 8236058

[Severin Gehwolf]

Hi,

On Wed, 2019-12-18 at 14:54 +0000, Sergey Nazarkin wrote:
> Hi!
> 
> I’ve created critical bug [1]  since debug build is broken after one of latest changeset [2].  Please consider to include it into u242
> 
> diff -r 9ef81b9152f1 src/share/vm/oops/instanceKlass.cpp 
> --- a/src/share/vm/oops/instanceKlass.cpp Fri Nov 13 18:14:41 2015 +0300 
> +++ b/src/share/vm/oops/instanceKlass.cpp Wed Dec 18 14:25:28 2019 +0300 
> @@ -3605,7 +3605,7 @@ 
>    bool good_state = is_shared() ? (_init_state <= state) 
>                                                 : (_init_state < state); 
>    assert(good_state || state == allocated, "illegal state transition"); 
> - set_initialization_state_and_notify_implassert(_init_thread == NULL, "should be cleared before state change"); 
> + assert(_init_thread == NULL, "should be cleared before state change"); 
>    _init_state = (u1)state; 
>  } 
>  #endif

This looks good to me. It's what the JDK 11u code[i] has as well. Not
sure why the backport for 8u was different.

Thanks,
Severin

[i] http://hg.openjdk.java.net/jdk-updates/jdk11u/file/ae96767b40ff/src/hotspot/share/oops/instanceKlass.cpp#l3684

> 
> Sergey Nazarkin
> 
> [1] https://bugs.openjdk.java.net/browse/JDK-8236178
> [2] https://bugs.openjdk.java.net/browse/JDK-8236058
>