[RFC] 8236174: Update javadoc since tags in the jfr backport

[Andrew John Hughes]

On 18/12/2019 16:33, Mario Torre wrote:
> Hi Andrew,
> 
> Yes, those are the JFR classes, they are public.
> 
> The CSR mentioned that: "The backport of the API looks appropriate for
> the goals of the project".
> 
> On the other hand, you have a point that there is not some discrepancy
> between 8 and later version whose javadocs says those classes were
> introduced in 9. Perhaps we should not have the since updated... Any
> ideas? I already pushed but we can rollback the patch if necessary.
> 
> Cheers,
> Mario
> 
> On Wed, Dec 18, 2019 at 5:29 PM Andrew John Hughes
> <gnu.andrew at redhat.com> wrote:
>>
>>
>>
>> On 18/12/2019 16:02, Mario Torre wrote:
>>> Again from Marcus:
>>>
>>> Jira:  https://bugs.openjdk.java.net/browse/JDK-8236174
>>> Webrev: http://cr.openjdk.java.net/~hirt/JDK-8236174/webrev.0/
>>>
>>> I tested the patch and is approved.
>>>
>>> Cheers,
>>> Mario
>>>
>>
>> Are these classes documented publicly?
>>
>> If not, I suggest not backporting this, otherwise it'll just create
>> backport headaches.
>> --
>> Andrew :)
>>
>> Senior Free Java Software Engineer
>> Red Hat, Inc. (http://www.redhat.com)
>>
>> PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
>> Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
>> https://keybase.io/gnu_andrew
>>
> 
> 

If they're public, then fixing it is the right thing to do. Backports
will just have to work around it. I was concerned that it was being done
for classes for which Javadocs will never actually be generated, which
applies to a few methods added within the JDK codebase where I've left
the @since as it was in the backport.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew