[8u] RFR 8215032: Support Kerberos cross-realm referrals (RFC 6806)

[Andrew John Hughes]

On 04/11/2019 18:41, Martin Balao wrote:
> Hi,
> 
> I'd like to request a review for the 8u backport of 8215032 [1].
> 
> CSR for 8u requested here [2].
> 
> Webrev.00:
> 
>  *
> http://cr.openjdk.java.net/~mbalao/webrevs/8215032/8215032.jdk8u.jdk.webrev.00/
> 
> Changes from 11u patch [3]:
> 
>  * File paths
> 
>  * java.security changes need to be populated through the different
> java.security-<OS> files
> 
>  * Copyright dates
>   * KerberosPrincipal.java
>   * Checksum.java
>   * Config.java
>   * KrbAsRep.java
>   * KrbTgsRep.java
>   * PAData.java
>   * KrbTgsReq.java
> 
>  * Failing hooks because of the context (no actual code changes)
>   * KrbAsReq.java
>    * Manually added "import java.util.Arrays;"
>   * EncKDCRepPart.java
>    * 8u has "<xmp>" tags because 8132130 was not backported to 8u
>    * Manually replaced the structure adding "encrypted-pa-data [12]
> SEQUENCE OF PA-DATA OPTIONAL"
>   * KDC.java
>    * Indentation issues
> 
>  * KrbTgsReq.java
>   * "Arrays" already imported (introduced in 6355584 and not removed
> since then)
> 
>  * ReferralsTest.java
>   * @library jtreg header removed
> 
> Testing:
> 
>  * No regressions found in sun/security/krb5
> 
> Thanks,
> Martin.-
> 
> --
> [1] - https://bugs.openjdk.java.net/browse/JDK-8215032
> [2] - https://bugs.openjdk.java.net/browse/JDK-8233512
> [3] - http://hg.openjdk.java.net/jdk-updates/jdk11u-dev/rev/f2b580a5721c
> 

Looks good to me.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew