[8u] RFR: 8143925 : enhancing CounterMode.crypt() for AESCrypt.implEncryptBlock() + 8146581 : Minor corrections to the patch submitted for earlier bug id - 8143925

[Andrew John Hughes]

On 20/12/2019 01:33, Anton Kozlov wrote:
> Hi,
> 
> please review a backport of JDK-8143925:
> 
>   http://cr.openjdk.java.net/~akozlov/8143925/hotspot.00/
>   http://cr.openjdk.java.net/~akozlov/8143925/jdk.00/
> 
> and of JDK-8146581:
> 
>   http://cr.openjdk.java.net/~akozlov/8146581/webrev.00/
> 

Please keep to one bug review per thread for simplicity.

> Adjustments for JDK-8143925 are
> hotspot:
>  * vm_version_aarch64.cpp is missing 
>  * assembler_x86.[ch]pp - xorb and added instructions encoding with AVX-1
>  * stubRoutines_x86.hpp, vm_version_x86.cpp - no CRC32C intrinsic
>    - no generate_CRC32C_table
>    - no UseCRC32CIntrinsics
>  * stubRoutines_x86_{32,64}.hpp - code_size2 increased accrodingly
>  * stubGenerator_x86_{32,64}.cpp - remove AVX-512 related code
>  * vmSymbols.cpp, c2compiler.cpp, library_call.cpp  - adjustments for intrinsics framework, parameter to Node::operator new()
>  * TestAESBase.java, TestAESMain.java - different path
> jdk:
>  * CounterMode.java - no @HotSpotIntrinsicCandidate, use existing range check utils
> 

Looks good to me, though I think this warrants a second review from
someone more familiar with the HotSpot side.

> For JDK-8146581: 
>  * vm_version_x86.cpp - no CRC32C intrinsic
> 
> Thanks,
> Anton
> 

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew