Backport vmTestbase tests to jdk8u-dev?

[Andrew John Hughes]

On 29/12/2019 19:35, Liu, Xin wrote:
> Hi, Maintainers, 
> 
> I put answers inline.
> 
> Please provide the following info for this work:
>    1. Prepare patches for all affected repositories. List the repositories
>       affected. Send a link to patches which apply to current jdk8u-dev
>       HEAD.
> we will touch two repos. 
> a) jdk8u-dev repo: 
>     1. https://cr.openjdk.java.net/~xliu/8231089/root/webrev/
> b) jdk8u-dev/hotspot
>     1. base                         https://cr.openjdk.java.net/~xliu/8231089/base.patch.tar.gz
>     2. updateAPIs             https://cr.openjdk.java.net/~xliu/8231089/updateAPIs.patch
>     3. classFileInstaller    https://cr.openjdk.java.net/~xliu/8231089/classFileInstaller/webrev/
>     4. gclog                        https://cr.openjdk.java.net/~xliu/8231089/gclog/webrev/
>     5. nativeLibraries       https://cr.openjdk.java.net/~xliu/8231089/nativeLibraries/webrev/
>     6. azul_contrib1         https://cr.openjdk.java.net/~xliu/8231089/azul_contrib.patch
>     7. azul_contrib2         https://cr.openjdk.java.net/~xliu/8231089/azul_contrib2.patch
>     8. new_targets           https://cr.openjdk.java.net/~xliu/8231089/new_targets/01/webrev/
> 

Where does all this originate from? JDK-8231089 seems to be a freshly
created bug rather than an issue resolved in later JDK versions being
backported.

>    2. Tell us on which platforms and architectures you've built/run those
>       tests.
> I ran on linux_x86-64 and linux_aarch64.
> 
>    3. Send a diff stat of the patches. This is to ensure only test
>       directories are being touched.
> Please refer to the attachment vmTestbase.status.zip. it enlists all changed files. 
> I understand your concern. That's our intention too. I prefer to keep the file layout intact.  It's because it would be easier to update vmTestbase in the future. 
> 
>    4. Provide instructions as to how these tests can be run.
> Please refer to the script attached. Two functions are provided. 
> apply_vmTestbase apply patches. 
> run_vmTestbase kicks  off vmTestbase test.
> 
>    5. The patch should eventually get pushed under a single bug, JDK-
>       8231089. That means adding vmTestbase code should be a single big
>       commit when pushed. So please squash any changes you may have.
> Sure. I will do that. The reason I'd like to keep mq format now because it's easy to modify commits.  
> 
>   6. The commit message should perhaps also mention "JDK-8199257:
>       [TESTBUG] Open source VM testbase metaspace tests" as it also
>       includes those? An eventual push would then list a backport of this
>       bug.
> Yes, it includes.  I copy vmTestbase blob from jdk-14+14. I also double-check the log. It includes those metaspace changes. 
> 
> For test stats, so far, it passed 3480 tests and I put 82 tests in a ProblemList(https://cr.openjdk.java.net/~xliu/8231089/new_targets/01/webrev/test/ProblemList-vmTestbase.txt.html)
> 

Why is JDK-8199257 not the patch being backported here?

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew