[8u] RFR 8165996: PKCS11 using NSS throws an error regarding secmod.db when NSS uses sqlite

[Andrew John Hughes]

On 06/11/2019 18:39, Martin Balao wrote:
> Hi,
> 
> I'd like to propose the 8u backport of 8165996 [1]. This have been
> proposed long time ago but I've now rebased the work and bumped the
> webrev version to 02.
> 
> Webrev.02:
> 
>  *
> http://cr.openjdk.java.net/~mbalao/webrevs/8165996/8165996.jdk8u.jdk.webrev.02/
> 
> Differences with JDK baseline patch [2]:
> 
>  * TestNssDbSqlite.java
>   * @modules jtreg header removed
>   * Added a check to avoid errors when initialization fails (proposed by
> @coffeys)

I don't see this in the main OpenJDK repository. It should be added
there first, not proposed in a backport.

>   * Removed white space in "initializeProvider" method signature
> 
>  * PKCS11Test.java
>   * Change does not apply to 8u: no "distro" function in PKCS11Test
>    * This was apparently introduced by 8133318 to solve issues in
> Solaris SPARC 11.1 and earlier
> 

I don't think this should simply be dropped on the floor.

I backported both this bug & JDK-8133318 myself some time ago [0] [1]
[2] so I'll look at bringing the pre-requisites upstream so this can be
backported fully.

> Testing:
> 
>  * No regression found in sun/security/pkcs11
> 
> Note: a followup fix (8195607) will be proposed after this one.
> 
> Thanks,
> Martin.-
> 
> --
> [1] - https://bugs.openjdk.java.net/browse/JDK-8165996
> [2] - http://hg.openjdk.java.net/jdk/jdk/rev/55b9b1e184c6
> 

[0] https://icedtea.classpath.org/bugzilla/show_bug.cgi?id=3337
[1] https://icedtea.classpath.org/bugzilla/show_bug.cgi?id=3506
[2]
https://icedtea.classpath.org//hg/icedtea8-forest/jdk?cmd=changeset;node=252ab42bb0dd

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew