[8u] RFR (XS) 8218613: [TESTBUG] runtime/ErrorHandling tests are building incorrect testlibrary classes

David Holmes david.holmes at oracle.com
Thu Feb 7 12:31:09 UTC 2019


On 7/02/2019 9:52 pm, Aleksey Shipilev wrote:
> Bug:
>    https://bugs.openjdk.java.net/browse/JDK-8218613
> 
> This is botched backport to 8u, which fails the jtreg tests now in 8u. Note the fix is not the
> backport, but the actual 8u-specific fix.

IIRC the incorrect @build is not a fatal error for earlier jtreg 
version. AFAICS we still use jtreg 4.1 for testing 8u internally.

David

> Fix:
> 
> diff -r 1d64329dec0a -r 38c789c8c590 test/runtime/ErrorHandling/TestCrashOnOutOfMemoryError.java
> --- a/test/runtime/ErrorHandling/TestCrashOnOutOfMemoryError.java       Thu Feb 07 10:59:56 2019 +0100
> +++ b/test/runtime/ErrorHandling/TestCrashOnOutOfMemoryError.java       Thu Feb 07 12:50:38 2019 +0100
> @@ -25,7 +25,7 @@
>    * @test TestCrashOnOutOfMemoryError
>    * @summary Test using -XX:+CrashOnOutOfMemoryError
>    * @library /testlibrary
> - * @build jdk.test.lib.*
> + * @build com.oracle.java.testlibrary.*
>    * @run driver TestCrashOnOutOfMemoryError
>    * @bug 8138745
>    */
> diff -r 1d64329dec0a -r 38c789c8c590 test/runtime/ErrorHandling/TestExitOnOutOfMemoryError.java
> --- a/test/runtime/ErrorHandling/TestExitOnOutOfMemoryError.java        Thu Feb 07 10:59:56 2019 +0100
> +++ b/test/runtime/ErrorHandling/TestExitOnOutOfMemoryError.java        Thu Feb 07 12:50:38 2019 +0100
> @@ -25,7 +25,7 @@
>    * @test TestExitOnOutOfMemoryError
>    * @summary Test using -XX:ExitOnOutOfMemoryError
>    * @library /testlibrary
> - * @build jdk.test.lib.*
> + * @build com.oracle.java.testlibrary.*
>    * @run driver TestExitOnOutOfMemoryError
>    * @bug 8138745
>    */
> 
> Testing: Linux x86_64 fastdebug, jtreg runtime/ErrorHandling
> 
> Thanks,
> -Aleksey
> 


More information about the jdk8u-dev mailing list