[8u] RFA (XS) 8214061: Buffer written into itself

[Aleksey Shipilev]

This should be "RFA", because fix applies without conflicts, fixed header.

-Aleksey

On 2/12/19 3:35 PM, Aleksey Shipilev wrote:
> Please approve the push of trivial fix that makes the code correct and also resolves a compiler warning.
> 
>   Original Bug:
>       URL: https://bugs.openjdk.java.net/browse/JDK-8214061
>       Reporter: Severin Gehwolf
>       Assignee: Severin Gehwolf
>       Priority: P4
>       Components: core-svc
> 
>   Original Fix:
>         12: JDK-8214061, http://hg.openjdk.java.net/jdk/jdk/rev/8527b6100a59, 70 day(s) ago
> 
>   Backports and Forwardports:
>         11: 11.0.3, JDK-8217003, http://hg.openjdk.java.net/jdk-updates/jdk11u/rev/4f3e66062582, 29
> day(s) ago
>          8: MISSING
> 
> Patch applies to 8u with reshuffling and fuzz. Here it is, for reference:
> 
> diff -r b6dcf8ae496c src/share/back/debugInit.c
> --- a/src/share/back/debugInit.c        Wed Feb 06 04:09:08 2019 +0000
> +++ b/src/share/back/debugInit.c        Tue Feb 12 15:25:48 2019 +0100
> @@ -1,7 +1,7 @@
>  /*
> - * Copyright (c) 1998, 2012, Oracle and/or its affiliates. All rights reserved.
> + * Copyright (c) 1998, 2018, Oracle and/or its affiliates. All rights reserved.
>   * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>   *
>   * This code is free software; you can redistribute it and/or modify it
>   * under the terms of the GNU General Public License version 2 only, as
>   * published by the Free Software Foundation.  Oracle designates this
> @@ -663,11 +663,11 @@
>      }
>      if ( error != JVMTI_ERROR_NONE ) {
>          (void)snprintf(buf, sizeof(buf), "JDWP %s, jvmtiError=%s(%d)",
>                      msg, jvmtiErrorText(error), error);
>      } else {
> -        (void)snprintf(buf, sizeof(buf), "JDWP %s", buf);
> +        (void)snprintf(buf, sizeof(buf), "JDWP %s", msg);
>      }
>      if (env != NULL) {
>          (*((*env)->FatalError))(env, buf);
>      } else {
>          /* Should rarely ever reach here, means VM is really dead */
> 
> 
> Testing: Linux x86_64 build, hotspot jtregs (some unrelated failures)
> 
> Thanks,
> -Aleksey
>