[8u] RFR (XS) 8214061: Buffer written into itself

[Andrew Hughes]

On Thu, 14 Feb 2019 at 22:24, Hohensee, Paul <hohensee at amazon.com> wrote:
>
> Lgtm, need a Maintainer approval.
>
> Paul
>
> On 2/12/19, 6:37 AM, "jdk8u-dev on behalf of Aleksey Shipilev" <jdk8u-dev-bounces at openjdk.java.net on behalf of shade at redhat.com> wrote:
>
>     Please approve the push of trivial fix that makes the code correct and also resolves a compiler warning.
>
>       Original Bug:
>           URL: https://bugs.openjdk.java.net/browse/JDK-8214061
>           Reporter: Severin Gehwolf
>           Assignee: Severin Gehwolf
>           Priority: P4
>           Components: core-svc
>
>       Original Fix:
>             12: JDK-8214061, http://hg.openjdk.java.net/jdk/jdk/rev/8527b6100a59, 70 day(s) ago
>
>       Backports and Forwardports:
>             11: 11.0.3, JDK-8217003, http://hg.openjdk.java.net/jdk-updates/jdk11u/rev/4f3e66062582, 29
>     day(s) ago
>              8: MISSING
>
>     Patch applies to 8u with reshuffling and fuzz. Here it is, for reference:
>
>     diff -r b6dcf8ae496c src/share/back/debugInit.c
>     --- a/src/share/back/debugInit.c        Wed Feb 06 04:09:08 2019 +0000
>     +++ b/src/share/back/debugInit.c        Tue Feb 12 15:25:48 2019 +0100
>     @@ -1,7 +1,7 @@
>      /*
>     - * Copyright (c) 1998, 2012, Oracle and/or its affiliates. All rights reserved.
>     + * Copyright (c) 1998, 2018, Oracle and/or its affiliates. All rights reserved.
>       * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>       *
>       * This code is free software; you can redistribute it and/or modify it
>       * under the terms of the GNU General Public License version 2 only, as
>       * published by the Free Software Foundation.  Oracle designates this
>     @@ -663,11 +663,11 @@
>          }
>          if ( error != JVMTI_ERROR_NONE ) {
>              (void)snprintf(buf, sizeof(buf), "JDWP %s, jvmtiError=%s(%d)",
>                          msg, jvmtiErrorText(error), error);
>          } else {
>     -        (void)snprintf(buf, sizeof(buf), "JDWP %s", buf);
>     +        (void)snprintf(buf, sizeof(buf), "JDWP %s", msg);
>          }
>          if (env != NULL) {
>              (*((*env)->FatalError))(env, buf);
>          } else {
>              /* Should rarely ever reach here, means VM is really dead */
>
>
>     Testing: Linux x86_64 build, hotspot jtregs (some unrelated failures)
>
>     Thanks,
>     -Aleksey
>
>
>

Approved.
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Web Site: http://fuseyism.com
Twitter: https://twitter.com/gnu_andrew_java
PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222