Proposal for back-porting JFR to OpenJDK8u

[Mario Torre]

On Tue, Feb 26, 2019 at 2:42 PM Andrey Petushkov <andrey at azul.com> wrote:
>
>
>
> On 26 Feb 2019, at 12:13, Mario Torre <neugens at redhat.com> wrote:
>
> > We are carrying analysis of what following JFR-related code changes to bring from jdk12+
>
> I don't think we should do that for every new baseline, I think integrating the platform changes from 11 to 8 is already a really big step, without endlessly backporting features from every other release down the line.
>
> We thought that it is a good idea to at watch them, at least to don't miss anything important. And given the number of such fixes happened in last 10 months it looks like having the JFR implementation open-sourced brought significant interest which possibly indicates there were number of bugs which deserve to be fixed


Yes, watching the changes is certainly good in the optic of searching
for bug (and security) fixes, I didn't mean to stop this effort, I'm
worried about backport features (like new events and perhaps APIs) to
8 however.
>
>
> I also would like to proceed with the current patches before adding more to the table as this is already a quite difficult patch to properly review and test without thinking about changes in further releases.
>
> No problem, we can submit additional changes as a separate review requests so community can decide whether and what to take

Yes, exactly!

I would suggest to wait for your patch with the integrated
functionality and then we can proceed with a proper review cycle and
push into the incubator repository [1].

Cheers,
Mario

[1] https://hg.openjdk.java.net/jdk8u/jdk8u-jfr-incubator/

-- 
Mario Torre
Associate Manager, Software Engineering
Red Hat GmbH <https://www.redhat.com>
9704 A60C B4BE A8B8 0F30  9205 5D7E 4952 3F65 7898