[PATCH][jdk8u] hotspot: Avoid calling vm_update with a NULL name

[Andrew Hughes]

On Thu, 3 Jan 2019 at 04:42, Siddhesh Poyarekar <siddhesh at gotplt.org> wrote:
>
> On 03/01/19 10:02 AM, Andrew Hughes wrote:
> > I assume you mean gcc 8 in your opening sentence, as I don't see this
> > with 7.
>
> I saw this with gcc 7.3 on aarch64.  Oddly, this doesn't get flagged
> with gcc 8.x on x86_64; I don't have 7.x on my x86 box to try
> unfortunately.  However the fix seems pretty obvious, which is why I
> proposed it.
>
> I don't mind doing additional tests if that's necessary, just that it
> will take a bit longer since I'll have to build gcc 7 branch for it.

Ah, ok, I don't see the same with gcc 7.3 on x86_64. No problem there
though, and no need for more testing. It's just interesting.

>
> > Usually the route for OpenJDK fixes is to apply them to the current working
> > tree first (https://hg.openjdk.java.net/jdk) and then backport to
> > other supported
> > trees (currently 11, 8, 7 and 6).
> > However, this file seems to have been removed during the development of
> > OpenJDK 10 [0] so the change could straight into 8u.
> >
> > Have you followed the process at [1] and signed the Oracle Contributor
> > Agreement?
>
> I work for Linaro so I should be covered under Linaro's agreement.
>

Yeah, I saw that in your other e-mail after replying.

I've filed a bug for it:

https://bugs.openjdk.java.net/browse/JDK-8216037

and you can consider it reviewed by me. If you post a formal approval
(see [0]), then we can get it fixed. At the moment, there's both a review
and approval process for 8u, while it's maintained by Oracle.

It'll get pulled into the aarch64 tree when we sync with a release the
fix is in (I'd assume around the time of the April security update).

> Thanks,
> Siddhesh

[0] https://openjdk.java.net/projects/jdk8u/approval-template.html
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Web Site: http://fuseyism.com
Twitter: https://twitter.com/gnu_andrew_java
PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222