[PATCH][jdk8u] Override TESTDIRS correctly in hotspot

Andrew Hughes gnu.andrew at redhat.com
Thu Jan 3 04:54:21 UTC 2019


On Thu, 20 Dec 2018 at 13:09, Siddhesh Poyarekar <siddhesh at gotplt.org> wrote:
>
> Hi,
>
> I was trying to override TESTDIRS in the test run in hotspot to ensure
> that all of the hotspot tests run but couldn't do that.  It turns out
> this is because TESTDIRS is not overridden correctly; it needs the
> override directive to work correctly.  Attached patch allows me to run
> all of the tests in hotspot using `make test TESTDIRS=. PRODUCT_NAME=...`.
>
> Siddhesh
>
> PS: My contributions should be covered under my employer's (Linaro)
> copyright assignment.
>
> PPS: I ran into this while setting up the aarch64-port, so what's the
> right way to ensure that (if accepted) this fix makes it into the
> aarch64-port too?

This is still present in the current tree, though it's moved file:

https://hg.openjdk.java.net/jdk/jdk/file/tip/test/TestCommon.gmk#l324

So I'd suggest raising this on build-dev at openjdk.java.net and then
we can backport to 8u once it's fixed there.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Web Site: http://fuseyism.com
Twitter: https://twitter.com/gnu_andrew_java
PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222


More information about the jdk8u-dev mailing list