RFA: 8073139: PPC64: User-visible arch directory and os.arch value on ppc64le cause issues with Java tooling
Andrew Hughes
gnu.andrew at redhat.com
Thu Jan 10 04:58:00 UTC 2019
On Thu, 4 Oct 2018 at 17:49, Severin Gehwolf <sgehwolf at redhat.com> wrote:
>
> Hi,
>
> Please approve this 8u backport request related to ppc64le. When using
> a ppc64le build from 8u and pulling in natives from Maven etc. users
> might end up getting ppc64 (BE) binaries because of the way the JDK
> reports itself to the user.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8073139
> webrevs: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8073139/jdk8/01/
>
> Review thread of this 8u change:
> http://mail.openjdk.java.net/pipermail/build-dev/2018-September/023417.html
>
> The 8u change has been reviewed by David Holmes, Goetz Lindenmaier,
> Erik Joelsson. Not all changes from JDK 9 apply for the backport.
>
> Testing: Linux ppc64le/be builds and verifying os.arch property reports
> correctly. No change for ppc64be builds.
>
> Thanks,
> Severin
>
Why was this commit credited as 'sgehwolf' rather than the original
author, 'asmundak'?
https://hg.openjdk.java.net/jdk8u/jdk8u-dev/rev/a5b23c21a665
It's also missing the original Contributed-by line:
'Contributed-by: Andrew Hughes <gnu.andrew at redhat.com>, Alexander
Smundak <asmundak at google.com>'
https://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/2ff471390a03
Can we please make sure to retain the original authorship when making
such backports in future, please?
Thanks,
--
Andrew :)
Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)
Web Site: http://fuseyism.com
Twitter: https://twitter.com/gnu_andrew_java
PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222
More information about the jdk8u-dev
mailing list