[8u-dev] Request for approval for CR 8081202: Hotspot compile warning: "Invalid suffix on literal; C++11 requires a space between literal and identifier"

[Kevin Walls]

Hi Andrew,

I don't know if C++11 features will ever be wanted in 8u, so maybe this 
change could have been be avoided.  But code being the same or more 
similar in 8u compared to later versions is a generally good as it can 
help other changes get backported with fewer changes.  We could go back 
and forth on that balance I suppose...


On 14/01/2019 18:17, Andrew Hughes wrote:
> On Thu, 14 Jun 2018 at 14:47, Kevin Walls <kevin.walls at oracle.com> wrote:
>> Hi,
>>
>> I'd like to request approval to backport from 9 to 8u:
>>
>> 8081202: Hotspot compile warning: "Invalid suffix on literal; C++11
>> requires a space between literal and identifier"
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8081202
>>
>> 9 changeset:
>> http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/767f36deb0dc
>>
>> Original review thread:
>> http://mail.openjdk.java.net/pipermail/hotspot-dev/2015-May/018677.html
>>
>> Proposed 8u change:
>> http://cr.openjdk.java.net/~kevinw/8081202/webrev.00/
>>
>> This doesn't all backport cleanly, but the manual work is very very
>> routine, and all about adding a space between a " and a macro.  It
>> changes 76 files.
>>
>> Testing has gone OK, this doesn't change the regular jdk8 builds.
>>
>> Thanks!
>> Kevin
>>
> Why were all these C++11 changes backported rather than just turning off C++11
> as we do on GNU/Linux?
> This is now causing a lot of merge issues when updating to 8u192.