[8u-dev] RFA: JDK-8215934: G1 Old Gen MemoryPool CollectionUsage.used values don't reflect mixed GC results

[Hohensee, Paul]

Done. New webrev: http://cr.openjdk.java.net/~phh/8215934/webrev.01

Thanks,

Paul

On 1/23/19, 10:07 AM, "Andrew Hughes" <gnu.andrew at redhat.com> wrote:

    On Tue, 22 Jan 2019 at 00:03, Hohensee, Paul <hohensee at amazon.com> wrote:
    >
    > Please approve a G1 serviceability bug backport.
    >
    > JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8215934
    > CSR: https://bugs.openjdk.java.net/browse/JDK-8215935
    > Webrev: http://cr.openjdk.java.net/~phh/8215934/webrev.00/
    >
    > First backport review thread: http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2018-October/023507.html
    > Second backport review thread: https://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2019-January/024462.html
    > Backport reviewers: tschatzl, jcbeyler
    > Original JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8195115
    > Original CSR: https://bugs.openjdk.java.net/browse/JDK-8196719
    > Original review thread: http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2018-June/022305.html
    >
    >
    
    Can we please break the overly long @run line in
    test/gc/g1/mixedgc/TestOldGenCollectionUsage.java please?
    
    Something more along the lines of
    https://hg.openjdk.java.net/jdk/jdk/file/tip/test/hotspot/jtreg/gc/shenandoah/compiler/TestNullCheck.java
    would be more legible.
    
    Thanks,
    -- 
    Andrew :)
    
    Senior Free Java Software Engineer
    Red Hat, Inc. (http://www.redhat.com)
    
    Web Site: http://fuseyism.com
    Twitter: https://twitter.com/gnu_andrew_java
    PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
    Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222