FW: Request to cherry-pick JDK-8215976, fix gmtime_r declaration conflicts in zip.cpp with linux header files

[Patrick Zhang]

Hi David,

Yes I did it in my previous email (Jan 24), and re-attached it here as well.

Regards
Patrick

-----Original Message-----
From: David Holmes <david.holmes at oracle.com> 
Sent: Monday, January 28, 2019 11:22 AM
To: Patrick Zhang <patrick at os.amperecomputing.com>; jdk8u-dev at openjdk.java.net
Subject: Re: FW: Request to cherry-pick JDK-8215976, fix gmtime_r declaration conflicts in zip.cpp with linux header files

Patrick,

You need a patch that will apply to 8u. The jdk/jdk patch can't be imported directly due to the file layout changes.

David

On 28/01/2019 1:02 pm, Patrick Zhang wrote:
> I don’t have commit permission, could anyone please help sponsor this backport? It is a simple patch, and verification has been done on jdk/submit. Thanks!
> 
> http://hg.openjdk.java.net/jdk/jdk/rev/06862c019f3f
> 
> Regards
> Patrick
> 
> -----Original Message-----
> From: jdk8u-dev <jdk8u-dev-bounces at openjdk.java.net> On Behalf Of 
> Patrick Zhang
> Sent: Thursday, January 24, 2019 11:00 AM
> To: jdk8u-dev at openjdk.java.net
> Subject: RE: FW: Request to cherry-pick JDK-8215976, fix gmtime_r 
> declaration conflicts in zip.cpp with linux header files
> 
> To whom could help sponsor this porting, attached is the patch file based on the latest tip of jdk8u.
> 
> Regards
> Patrick
> 
> -----Original Message-----
> From: jdk8u-dev <jdk8u-dev-bounces at openjdk.java.net> On Behalf Of 
> Patrick Zhang
> Sent: Thursday, January 24, 2019 10:28 AM
> To: Andrew Hughes <gnu.andrew at redhat.com>
> Cc: jdk8u-dev at openjdk.java.net
> Subject: RE: FW: Request to cherry-pick JDK-8215976, fix gmtime_r 
> declaration conflicts in zip.cpp with linux header files
> 
> Hi Andrew,
> 
> Yes this is a common issue so that jdk8u needs the fix as well. However aarch64-port/jdk8u-shenandoah is of higher priority since the problem can be more easily reproduced via GCC special builds (with customized sysroot, e.g. for cross-compilation purpose) than default builds.
> 
> I have no permission, may need a sponsor to help get the fix into upstream jdk8u, then aarch64-port/jdk8u-shenandoah.
> Thanks in advance.
> 
> Regards
> Patrick
> 
> -----Original Message-----
> From: Andrew Hughes <gnu.andrew at redhat.com>
> Sent: Wednesday, January 23, 2019 11:43 PM
> To: Patrick Zhang <patrick at os.amperecomputing.com>
> Cc: jdk8u-dev at openjdk.java.net
> Subject: Re: FW: Request to cherry-pick JDK-8215976, fix gmtime_r 
> declaration conflicts in zip.cpp with linux header files
> 
> On Wed, 23 Jan 2019 at 09:52, Patrick Zhang <patrick at os.amperecomputing.com> wrote:
>>
>> Please help review this cherry-pick request, thanks.
>>
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8215976
>> Changeset: http://hg.openjdk.java.net/jdk/jdk/rev/06862c019f3f
>> From: jdk/jdk, src/jdk.pack/share/native/common-unpack/zip.cpp
>> To: aarch64-port/jdk8u-shenandoah/jdk,
>> src/share/native/com/sun/java/util/jar/pack/zip.cpp
>>
> 
> Is the change unaltered for jdk8u, bar the path changes?
> 
> Thanks,
> --
> Andrew :)
> 
> Senior Free Java Software Engineer
> Red Hat, Inc. (http://www.redhat.com)
> 
> Web Site: http://fuseyism.com
> Twitter: https://twitter.com/gnu_andrew_java
> PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint 
> = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
> 
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: gmtime_8u.patch.txt
URL: <https://mail.openjdk.java.net/pipermail/jdk8u-dev/attachments/20190128/be9dae6b/gmtime_8u.patch-0001.txt>