FW: RFR: JDK8U Backport of JDK-8212941: Support new Japanese era in java.time.chrono.JapaneseEra

Seán Coffey sean.coffey at oracle.com
Mon Jan 28 16:30:47 UTC 2019


Thanks for the reviews. Here's the final webrev which I hope to sponsor 
for Deepak once I have the necessary approvals.

http://cr.openjdk.java.net/~coffeys/webrev.8212941.jdk8u/webrev/

Regards,
Sean.

On 28/01/19 16:06, Naoto Sato wrote:
> +1
>
> Naoto
>
> On 1/28/19 3:18 AM, Chris Hegarty wrote:
>>
>> On 27/01/2019 11:54, Deepak Kejriwal wrote:
>>> ...
>>> Hi All,
>>>
>>>
>>> JBS report: https://bugs.openjdk.java.net/browse/JDK-8212941
>>>
>>> Webrev: http://cr.openjdk.java.net/~rpatil/8212941/jdk8u/webrev.00/
>>
>> This looks good Deepak. Reviewed.
>>
>> One minor comment. "The of(int) and valueOf(String) methods ...", these
>> references could be javadoc links.



More information about the jdk8u-dev mailing list