Re: Proposal for back-porting JFR to OpenJDK8u

[guangyu.zhu]

The risk lies in other non-linux/x86-64 platforms. We have never built on them.

Thanks,
Guangyu
------------------------------------------------------------------
Sender:Hohensee, Paul <hohensee at amazon.com>
Sent At:2019 Jan. 31 (Thu.) 08:45
Recipient:Andrew Hughes <gnu.andrew at redhat.com>; Mario Torre <neugens at redhat.com>
Cc:jdk8u-dev <jdk8u-dev-bounces at openjdk.java.net>; yumin qi <yumin.qi at gmail.com>; jdk8u-dev <jdk8u-dev at openjdk.java.net>; kingsum.chow <kingsum.chow at gmail.com>; denghui.ddh <denghui.ddh at antfin.com>
Subject:Re: Proposal for back-porting JFR to OpenJDK8u

The backport is on the EnableJFR switch is true, but it's default false in the patch, so JFR is default off.

Paul

 On 1/30/19, 6:49 AM, "jdk8u-dev on behalf of Andrew Hughes" <jdk8u-dev-bounces at openjdk.java.net on behalf of gnu.andrew at redhat.com> wrote:

    On Wed, 30 Jan 2019 at 09:15, Mario Torre <neugens at redhat.com> wrote:
    >
    > Yeah, however I think we may need to be conservative with this, since the
    > stability of the platform has precedence over new features, so we need to
    > find some way to have a staging environment for those changes.
    >
    > Cheers,
    > Mario
    >
    > On Wed, Jan 30, 2019 at 9:37 AM guangyu.zhu <guangyu.zhu at aliyun.com> wrote:
    >
    > > Good suggestion! Paul
    > >
    > > Thanks,
    > > Guangyu
    > >

    I like Paul's suggestion. It's easier to have the core work in there
    and easily available
    for everyone to work on, than to try and create one perfect patch.
    It's also then easier
    to track what follow-on bugs have been fixed in 8u.

    Does the initial patch allow this to be disabled? The risk is
    significantly reduced if it
    is still possible to build as now with it applied.

    Thanks,
    -- 
    Andrew :)

    Senior Free Java Software Engineer
    Red Hat, Inc. (http://www.redhat.com)

    Web Site: http://fuseyism.com
    Twitter: https://twitter.com/gnu_andrew_java
    PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
    Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222