[8u] RFR: 8210761: libjsig is being compiled without optimization

[Severin Gehwolf]

Hi Christoph,

On Thu, 2019-07-04 at 10:24 +0000, Langer, Christoph wrote:
> Hi Severin,
> 
> sorry, this item got drained down in my pile of work.
> 
> AIX looks good. For Solaris, however, there is a problem.
> 
> This is an excerpt of the logs:
> SS12u1/SUNWspro/bin/cc -g -xs -m64 -xarch=sparc -G -KPIC \
>                          -M jdk8/hotspot/make/solaris/makefiles/mapfile-vers-jsig -mt -xnolib -xO4  -g0 -xs -o libjsig.so sun_64/nightly/jdk8/hotspot/src/os/solaris/vm/jsig.c -ldl
> cc: Warning: Option -0 passed to ld, if ld is invoked, ignored otherwise
> ld: fatal: unrecognized option '-0'
> ld: fatal: use the '-z help' option for usage information

Thanks for this info!

> Seems like the options don't work for Oracle Studio (12 u1) when
> compiling and linking in one go. A fix would be to split compilation
> and linking of the lib into 2 steps, I guess.

As I don't have access to such a system and test a potential patch,
I've removed the solaris changes:

http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8210761/jdk8/03/webrev/

If somebody is able to provide me with a solaris patch, I can happily
include it. Otherwise, solaris will stay as-is.

Thoughts? OK to push?

Thanks,
Severin

> Best regards
> Christoph
> 
> 
> > -----Original Message-----
> > From: Severin Gehwolf <sgehwolf at redhat.com>
> > Sent: Donnerstag, 4. Juli 2019 11:39
> > To: Langer, Christoph <christoph.langer at sap.com>; Andrew John Hughes
> > <gnu.andrew at redhat.com>; jdk8u-dev <jdk8u-dev at openjdk.java.net>
> > Cc: build-dev <build-dev at openjdk.java.net>
> > Subject: Re: [8u] RFR: 8210761: libjsig is being compiled without optimization
> > 
> > Hi Christoph,
> > 
> > On Wed, 2019-06-26 at 13:11 +0000, Langer, Christoph wrote:
> > > > Here you go:
> > > > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-
> > > > 8210761/jdk8/02/webrev/
> > > > 
> > > > I cannot really test on bsd, solaris or aix, though :( Appreciate any
> > > > testers for those platforms.
> > > 
> > > I pulled the patch into our test environment. It will be run for AIX
> > > and solaris there. Will let you know the results...
> > 
> > Any update?
> > 
> > Thanks,
> > Severin