[8u] RFR: 8210761: libjsig is being compiled without optimization

[Severin Gehwolf]

Hi Christoph,

On Wed, 2019-07-10 at 09:08 +0000, Langer, Christoph wrote:
> Hi Severin,
> 
> You made a little mistake. It must be "-xO4" instead of "-x04" in the
> Solaris build file (It's the letter O instead of the number 0) ��

Sigh. Take 5:
http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8210761/jdk8/05/webrev/

Thanks again for your help!

Cheers,
Severin

> 
> Best regards
> Christoph
> 
> > -----Original Message-----
> > From: Severin Gehwolf <sgehwolf at redhat.com>
> > Sent: Dienstag, 9. Juli 2019 12:09
> > To: Langer, Christoph <christoph.langer at sap.com>
> > Cc: build-dev <build-dev at openjdk.java.net>; Andrew John Hughes
> > <gnu.andrew at redhat.com>; jdk8u-dev <jdk8u-dev at openjdk.java.net>
> > Subject: Re: [8u] RFR: 8210761: libjsig is being compiled without
> > optimization
> > 
> > Hi Christoph,
> > 
> > On Mon, 2019-07-08 at 21:42 +0000, Langer, Christoph wrote:
> > > Hi Severin,
> > > 
> > > I have a solution for Solaris.
> > > 
> > > In your webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-
> > 8210761/jdk8/02/webrev/, make/solaris/makefiles/jsig.make, Line 52:
> > JSIG_OPT_FLAGS = $(OPT_CFLAGS)
> > > Should be: JSIG_OPT_FLAGS = -xO4 -g
> > > 
> > > OPT_CFLAGS are the opt flags for the C++ compiler, but libjsig.o
> > > is compiled
> > with the C compiler. And the C compiler does not like -g0 but needs
> > just -g.
> > 
> > Thanks! webrev #04 is here:
> > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-
> > 8210761/jdk8/04/webrev/
> > 
> > Good to go?
> > 
> > Thanks,
> > Severin
> > > -----Original Message-----
> > From: Langer, Christoph
> > Sent: Donnerstag, 4. Juli 2019 14:21
> > To: Severin Gehwolf <sgehwolf at redhat.com>; Andrew John Hughes
> > <gnu.andrew at redhat.com>; jdk8u-dev <jdk8u-dev at openjdk.java.net>
> > Cc: build-dev <build-dev at openjdk.java.net>
> > Subject: RE: [8u] RFR: 8210761: libjsig is being compiled without
> > optimization
> > 
> > Hi Severin,
> > 
> > as we have the Solaris infrastructure in-house, let me try to
> > produce
> > something for Solaris. I'll get back to you soon...
> > 
> > Cheers
> > Christoph
> > 
> > -----Original Message-----
> > From: Severin Gehwolf <sgehwolf at redhat.com>
> > Sent: Donnerstag, 4. Juli 2019 14:18
> > To: Langer, Christoph <christoph.langer at sap.com>; Andrew John
> > Hughes
> > <gnu.andrew at redhat.com>; jdk8u-dev <jdk8u-dev at openjdk.java.net>
> > Cc: build-dev <build-dev at openjdk.java.net>
> > Subject: Re: [8u] RFR: 8210761: libjsig is being compiled without
> > optimization
> > Hi Christoph,
> > 
> > On Thu, 2019-07-04 at 10:24 +0000, Langer, Christoph wrote:
> > Hi Severin,
> > 
> > sorry, this item got drained down in my pile of work.
> > 
> > AIX looks good. For Solaris, however, there is a problem.
> > 
> > This is an excerpt of the logs:
> > SS12u1/SUNWspro/bin/cc -g -xs -m64 -xarch=sparc -G -KPIC \
> >                          -M
> > jdk8/hotspot/make/solaris/makefiles/mapfile-vers-jsig -
> > mt
> > -xnolib -xO4  -g0 -xs -o libjsig.so
> > sun_64/nightly/jdk8/hotspot/src/os/solaris/vm/jsig.c -ldl
> > cc: Warning: Option -0 passed to ld, if ld is invoked, ignored
> > otherwise
> > ld: fatal: unrecognized option '-0'
> > ld: fatal: use the '-z help' option for usage information
> > 
> > Thanks for this info!
> > 
> > Seems like the options don't work for Oracle Studio (12 u1) when
> > compiling and linking in one go. A fix would be to split
> > compilation
> > and linking of the lib into 2 steps, I guess.
> > 
> > As I don't have access to such a system and test a potential patch,
> > I've removed the solaris changes:
> > 
> > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-
> > 8210761/jdk8/03/webrev/
> > 
> > If somebody is able to provide me with a solaris patch, I can
> > happily
> > include it. Otherwise, solaris will stay as-is.
> > 
> > Thoughts? OK to push?
> > 
> > Thanks,
> > Severin
> > 
> > Best regards
> > Christoph
> > 
> > 
> > -----Original Message-----
> > From: Severin Gehwolf <sgehwolf at redhat.com>
> > Sent: Donnerstag, 4. Juli 2019 11:39
> > To: Langer, Christoph <christoph.langer at sap.com>; Andrew John
> > Hughes
> > <gnu.andrew at redhat.com>; jdk8u-dev <jdk8u-
> > dev at openjdk.java.net>
> > Cc: build-dev <build-dev at openjdk.java.net>
> > Subject: Re: [8u] RFR: 8210761: libjsig is being compiled without
> > optimization
> > Hi Christoph,
> > 
> > On Wed, 2019-06-26 at 13:11 +0000, Langer, Christoph wrote:
> > Here you go:
> > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-
> > 8210761/jdk8/02/webrev/
> > 
> > I cannot really test on bsd, solaris or aix, though :( Appreciate
> > any
> > testers for those platforms.
> > 
> > I pulled the patch into our test environment. It will be run for
> > AIX
> > and solaris there. Will let you know the results...
> > 
> > Any update?
> > 
> > Thanks,
> > Severin