RFR: [8u] JDK-8224560: (tz) Upgrade time-zone data to tzdata2019a

Dmitry Cherepanov dcherepanov at azul.com
Thu Jul 11 06:37:41 UTC 2019


Looks good to me.

One suggestion: does it make sense to include additional change in ZoneInfoFile.java to address the comment [1] in 8u too, it was fixed in the final patch for jdk/jdk13 [2].

Thanks,

Dmitry

[1] https://mail.openjdk.java.net/pipermail/core-libs-dev/2019-July/061216.html
[2] https://hg.openjdk.java.net/jdk/jdk13/rev/8df81df1cce4#l13.1

> On Jul 8, 2019, at 5:49 AM, Andrew John Hughes <gnu.andrew at redhat.com> wrote:
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8224560
> Webrev: https://cr.openjdk.java.net/~andrew/openjdk8/8224560/webrev.01/
> 
> This is the 8u version of the patch proposed in [0]. It mostly applies
> as is, but the CLDRConverter.java changes can be dropped (no JDK-8189784
> and friends in 8u). The changes to TestZoneInfo310.java ideally should
> be applied after JDK-8157792, which is a clean backport I have also
> flagged with jdk8u-fix-request.
> 
> I don't know whether we want to still try and include this in 8u222 or
> not. It is pretty late and people may already be testing finished builds.
> 
> Ok for 8u-dev?
> 
> [0] https://mail.openjdk.java.net/pipermail/i18n-dev/2019-July/002887.html
> 
> Thanks,
> -- 
> Andrew :)
> 
> Senior Free Java Software Engineer
> Red Hat, Inc. (http://www.redhat.com)
> 
> PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
> Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
> https://keybase.io/gnu_andrew



More information about the jdk8u-dev mailing list