[RFR 8u] 6913047: Long term memory leak when using PKCS11 and JCE exceeds 32 bit process address space

[Andrew John Hughes]

On 19/07/2019 22:08, Martin Balao wrote:
> Hi,
> 
> I'd like to request a review of the jdk8u backport of JDK-6913047 [1]:
> http://cr.openjdk.java.net/~mbalao/webrevs/6913047/6913047.webrev.jdk8u.jdk.00/
> 
> Patch applies cleanly (once jdk8u backport of JDK-6946830 [2] is
> applied), except for:
> 
>  * Trivial path changes
> 
>  * Trivial copyright date changes
> 
>  * mapfile-vers
>   * JDK-8 trivial change
> 
>  * P11Key.java
>   * Reordering changes mostly (minor)
> 
>  * P11Signature.java
>   * Reordering changes mostly (minor)
> 
> Testing:
> 
>  * No regressions found in sun/security/pkcs11
> 
>  * Manually forced key extraction and creation to test the new mechanism
>   * To improve performance, keys remain created until first use (same
> than in JDK-11 and JDK)
> 
> Thanks,
> Martin.-
> 
> --
> [1] - https://bugs.openjdk.java.net/browse/JDK-6913047
> [2] - https://bugs.openjdk.java.net/browse/JDK-6946830
> 

Changes look good to me, though the webrev seems to have also included
6946830. Please keep webrevs to just the patch being reviewed to make
the process easier.

I've pushed both on your behalf, prior to you getting commit access. I
await posts for JDK-8216597 & JDK-8220513.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew