[8u] RFR 8228405: Incorrect format strings in PhaseIdealLoop::rc_predicate

Andrew John Hughes gnu.andrew at redhat.com
Wed Jul 24 15:28:21 UTC 2019



On 24/07/2019 15:57, Aleksey Shipilev wrote:
> On 7/24/19 4:56 AM, Andrew John Hughes wrote:
>> Thus, in this case, the merge is probably the right place to do this
>> (even though it's a bit ugly). The alternative would have been to
>> regress part of 8182299 in 10 during the merge, and then re-apply it in
>> the form of the patch you've posted here.
>>
>> Of course, 8u doesn't have 8182299, so it was never fixed in either
>> version of loopPredicate.cpp.
>>
>> In short, patch looks fine to me. Simon has actually proposed a backport
>> of 8182299 that I haven't had chance to look at yet, so I don't know if
>> he also covered this or not.
> 
> Thanks. Just checking: we are fine with pushing the proposed patch to 8u then?
> 

Yes.
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew



More information about the jdk8u-dev mailing list