[8u] [PING?] RFR: 8222737: [TESTBUG] Allow for tier 1 like testing in OpenJDK 8u

[Andrew John Hughes]

On 30/07/2019 09:48, Andrew Dinn wrote:
> On 29/07/2019 19:30, Aleksey Shipilev wrote:
>> On 7/29/19 7:37 PM, Severin Gehwolf wrote:
>>> So, in light of the changed build system in JDK 9+, and the rather
>>> small changes in this patch (on the grand scheme of things), it seems
>>> reasonable to implement this feature in the way proposed. It's a JDK 8u
>>> *enhancement* after all.
>>
>> I am with Severin here. The lack of acceptance test profile in 8u is severely impeding 8u
>> backporting work. I personally keep Severin's patches applied at all times in my local patch queue,
>> because that is the only way I can have 8u coverage more or less similar to what I do for 11u backports.
>>
>> Langtools build changes do not look bad, and they are pretty isolated from the rest of build system,
>> which means we are not risking regressing important stuff.
> I agree that this is needed. I also understand why Andrew is loath to
> see changes that are not upstream. However, in this case I don't think
> we can avoid adding changes that cause a difference from upstream.
> 

I wouldn't say it's as extreme as loathing, but, if a big chunk of code
is being added, I just would like to know its origins, and, if they are
indeed new in this patch, give them the more through examination needed.

If I appear overly critical, put it down to a decade of doing such
backports and having had to work out where such forks in the codebase
come from, often on very tight deadlines. I'm trying to minimise
potential later angst at the expense of a little more perspiration now.

> The upstream test make system is implemented very differently, as
> Severin explained. He actually omitted mention of one important detail.
> From jdk9 onwards it is organised in one tree rather than separate
> subtrees. IN consequence the code Severin is replicating in the jdk8u
> langtools/test make file does actually exist in upstream jdk11u but it
> is in a /shared/ file (test/make/TestCommon.gmk). For what loosk liek a
> very weird reason this shared file is not directly included in the
> langtools/test make file (langtools seems to expect the test process to
> pirate on the jdk test make process using a different path to the test
> files). Anyway, it is clear that this sharing (or, indeed, pirating on
> the jdk make process) is not an option in jdk8u because the make
> processes run in separate trees. So, replicating the shared code seems
> to be the only option.

And, thanks, this is the answer I've been searching for. The langtools
additions do seem to have been copied from the other versions, which, in
turn, were moved to a shared location in 9 by JDK-8170629 [0] [1] [2]
[3] [4]. That makes sense and I'm fine with that.

For future reference, a lot of this back-and-forth could probably have
been avoided if the process to arrive at such changes had been explained
from the start.

> 
> regards,
> 
> 
> Andrew Dinn
> -----------
> Senior Principal Software Engineer
> Red Hat UK Ltd
> Registered in England and Wales under Company Registration No. 03798903
> Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander
> 

[0] https://hg.openjdk.java.net/jdk/jdk/rev/26156e756dfa
[1] https://hg.openjdk.java.net/jdk/jdk/rev/8dcc83c2d40e
[2] https://hg.openjdk.java.net/jdk/jdk/rev/ccef74161219
[3] https://hg.openjdk.java.net/jdk/jdk/rev/2435ff181f94
[4] https://hg.openjdk.java.net/jdk/jdk/rev/2ac2a6ef14a6
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew