RFC: backport of JDK-8210863: Remove Xrandr include files from JDK sources

[Mario Torre]

On Tue, Jul 30, 2019 at 4:55 PM Mario Torre <neugens at redhat.com> wrote:
>
> On Tue, Jul 30, 2019 at 3:02 PM Andrew John Hughes
> <gnu.andrew at redhat.com> wrote:
> >
> >
> >
> > On 30/07/2019 11:22, Mario Torre wrote:
> > > Hi all,
> > >
> > > I would like to backport the following bug into jdk8u-dev:
> > >
> > > https://bugs.openjdk.java.net/browse/JDK-8210863
> > >
> > > The patch is trivial, apart from the usual path changes, I had to
> > > manually remove the internal Xrandr headers since the version do not
> > > match exactly:
> > >
> > > http://cr.openjdk.java.net/~neugens/JDK-8210863/webrev.00/
> > >
> > > The original patch is here:
> > >
> > > http://hg.openjdk.java.net/jdk/jdk/rev/7d99b410be1b
> > >
> > > Cheers,
> > > Mario
> > >
> >
> > What is the motivation for this? JDK-8213944 would seem to be evidence
> > that the removal risks breakage and OpenJDK 8u is an older JDK which may
> > still need to be built on systems without Xrandr.
>
> If an older distribution doesn't support xrandr (which I doubt since
> this extensions is quite old) then it would not work anyway, as
> there's no implementation in this patch, just the header files.
>
> I think such cases would be covered by JDK-8213944 more appropriately,
> rather than fallback at runtime.

I didn't answer your question. I don't mind not pushing this patch or
holding it, the only reason why I did the backport is that is for
consistency with the Oracle JDK and because it has the redhat-interest
label, if the patch isn't necessary I suggest to remove the label.

Cheers,
Mario
-- 
Mario Torre
Associate Manager, Software Engineering
Red Hat GmbH <https://www.redhat.com>
9704 A60C B4BE A8B8 0F30  9205 5D7E 4952 3F65 7898