[RFR 8u] 8220513: Wrapper Key may get deleted when closing sessions in SunPKCS11 crypto provider

Andrew John Hughes gnu.andrew at redhat.com
Tue Jul 30 17:01:33 UTC 2019



On 26/07/2019 16:17, Martin Balao wrote:
> Hi Aleksey,
> 
> On 7/26/19 4:58 AM, Aleksey Shipilev wrote:
>>
>>> JDK patch applies cleanly, except for P11Key.java part (which requires
>>> some reordering) and paths.
>>
>> I assume this means no actual code changes, and just changing the order (of what? methods?)
>> somewhere. I cannot spot the difference against upstream change, though.
>>
> 
> Actually, this should have applied cleanly... hmm. Anyways, thanks!
> 
> Martin.-
> 

FWIW, it didn't because of:

@@ -237,6 +237,7 @@

 -        refList.add(this);
 +        refSet.add(this);
+         // TBD: run at some interval and not every time?
          drainRefQueueBounded();
      }

as 8u does not have 8098580: drainRefQueueBounds() puts pressure on
pool.size()

Anyway, pushed now.
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew



More information about the jdk8u-dev mailing list