RFC: backport of JDK-8215756: Memory leaks in the AWT on macOS

Simon Tooke stooke at redhat.com
Tue Jul 30 19:39:46 UTC 2019


On 7/30/2019 12:29 PM, Aleksey Shipilev wrote:
> On 7/30/19 6:18 PM, Simon Tooke wrote:
>> The patch is trivial, apart from the usual path changes.
>> I omitted one file change that was only a line ending difference, and fixed the copyright dates.
> Why omit it?

Because it's not in my usual workflow (translation: lazy) to verify
newline correctness in incoming patches.  It probably should be.

I can add that file patch back, but, for example, one of the other file
patches doesn't apply cleanly (after fixing paths), and it's due to
chunks that only update newlines (in code that's not there in JDK8).

I'm happy to add back the one newline fix, but since the patch needed
modification anyways, I limited the original scope.  Just let me know a
preference.

-s

>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8215756
>>
>> jdk8u patch:  http://cr.openjdk.java.net/~stooke/webrevs/jdk8215756-jdk8u/
>> Original patch: http://hg.openjdk.java.net/jdk/client/rev/64e7a73195c1
> Backport looks good, modulo newline omission.
>
> Again, if the patch applies cleanly, you don't need RFC/RFR, just do jdk8u-fix-request and "Fix
> Request" comments.
>



More information about the jdk8u-dev mailing list