[8u] RFR 8217785: Padding ParallelTaskTerminator::_offered_termination variable

Zhengyu Gu zgu at redhat.com
Tue Jul 30 23:01:34 UTC 2019


Hi Aleksey,

Thanks for reviewing. Webrev is updated according to your comments.

Webrev: http://cr.openjdk.java.net/~zgu/JDK-8217785-8u/webrev.01/index.html

Thanks,

-Zhengyu


On 7/30/19 10:58 AM, Aleksey Shipilev wrote:
> On 7/30/19 4:50 PM, Zhengyu Gu wrote:
>> 8u backport:
>> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8217785-8u/webrev.00/
> 
> I believe most of 8u code uses just this:
> 
>   char _pad_before[DEFAULT_CACHE_LINE_SIZE]
>   ...
>   char _pad_after[DEFAULT_CACHE_LINE_SIZE]
> 
> Therefore, I see no need in doing new defines, which also have potential to leak into global
> symbols, especially from the frequently used header like taskqueue.hpp. The change becomes
> three-liner then. You need to do #include "utilities/globalDefinitions.hpp" and two new field
> definitions.
> 


More information about the jdk8u-dev mailing list