RFR: 8202884 [backport]: SA: Attach/detach might fail on Linux if debugee application create/destroy threads during attaching

[Andrew John Hughes]

On 29/05/2019 18:28, Andrew John Hughes wrote:
> 
> 
> On 29/05/2019 09:12, Andrew Dinn wrote:
>> On 28/05/2019 18:39, Andrew John Hughes wrote:
>>> This looks mostly like a clean backport apart from:
>>>
>>> . . .
>>> It looks like the ATTACH_FAIL change has been lost and the
>>> ATTACH_THREAD_DEAD change moved to the block above. Was this deliberate?
>>
>> No, that was most definitely an accident. Thank you for spotting it.
>>
>> I could not test the patch (it is tricky to reproduce the error
>> scenario) but I did run a build. I was thinking "it ought not compile
>> with 'return false' in there" but unfortunately it does!
>>
>>> Rest looks ok.
>> I'll have updated the patch in place. Is it ok now?
>>
>> regards,
>>
>>
>> Andrew Dinn
>> -----------
>> Senior Principal Software Engineer
>> Red Hat UK Ltd
>> Registered in England and Wales under Company Registration No. 03798903
>> Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander
>>
> 
> Thanks. Revised version looks good to go :)
> 

This patch, along with JDK-8176237 & JDK-8173910, seem to have been
pushed to the wrong forest.

The correct forest for OpenJDK 8u changes is jdk8u-dev:

https://hg.openjdk.java.net/jdk8u/jdk8u-dev/

Please ensure you push to the correct forest in future.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew