[8u] RFR+RFA: 8030993, 8197930, 8170494: Pending JNI exceptions

[Andrew John Hughes]

On 12/06/2019 18:33, Aleksey Shipilev wrote:
> This is the bunch of related fixes:
>   http://cr.openjdk.java.net/~shade/8030993-8197930-8170494/webrev.8u.01/
> 
> *) 8030993: Check jdk/src/share/native/common/jni_util.c for JNI pending exceptions
> This one has no public bug, and the only thing we can do is to pick up the actual changeset:
> http://hg.openjdk.java.net/jdk/jdk/rev/7a464b795af5 -- it applies cleanly.
> 
> *) 8197930: JNI exception pending in initializeEncoding of jni_util.c
> This one depends on 8030993. Patch does not apply cleanly, because it expects Compact Strings that
> are not available in 8u. Left only "CHECK_NULL(String_init_ID);" from the original patch:
> http://hg.openjdk.java.net/jdk/jdk/rev/83fd54252ee4
> 
> *) 8170494: JNI exception pending in PlainDatagramSocketImpl.c
> The last in the bunch that finalizes the "Pending JNI exception" bug trail. Applies cleanly.
> 
> I added jdk8u-fix-request for the last two issues. There is no way to add the label to the first
> issue, because the bug is closed, please approve explicitly here.
> 
> Testing: hotspot_all, java/lang, java/io, java/nio tests
> 

Yeah, it's not that uncommon to encounter ones where the bug isn't
visible. We just found a couple in the history leading to JDK-8153732 as
well.

I've set jdk8u-fix-yes on the other two and changes to JDK-8197930 look
sensible. Consider them all approved.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew