RFC: backport of JDK-8209775: ISO 4217 Amendment #169 Update
Mario Torre
neugens at redhat.com
Mon Jun 24 13:41:22 UTC 2019
Hi Andrew and all,
This is the second attempt.
I backported together the related issues:
https://bugs.openjdk.java.net/browse/JDK-8187946
https://bugs.openjdk.java.net/browse/JDK-8193552
https://bugs.openjdk.java.net/browse/JDK-8209775
The changes apply almost cleanly, with some minor tweak, here's the
cumulative webrev:
http://cr.openjdk.java.net/~neugens/8209775-backport/webrev.00/
Here are the single backported patches if this is a bit easier to read:
http://cr.openjdk.java.net/~neugens/8209775-backport/webrev.00/8209775.patch
http://cr.openjdk.java.net/~neugens/8209775-backport/webrev.00/8193552.patch
http://cr.openjdk.java.net/~neugens/8209775-backport/webrev.00/8187946.patch
They apply in this order 8187946.patch, 8193552.patch, 8209775.patch.
The only thing missing is the change from version 2 to version 3 of
the CurrencyData.properties file format, this is done in
https://bugs.openjdk.java.net/browse/JDK-7102969 but I didn't backport
this in this current batch, I think we should consider if we want to
backport this too in the future.
Cheers,
Mario
On Tue, Jun 4, 2019 at 11:19 PM Andrew John Hughes
<gnu.andrew at redhat.com> wrote:
>
>
>
> On 04/06/2019 15:00, Mario Torre wrote:
> > Hi all,
> >
> > I would like to backport the following bug into jdk8u-dev:
> >
> > https://bugs.openjdk.java.net/browse/JDK-8209775
> >
> > The original patch built on top of a number of updates to the ISO 4217
> > file, but I decided for a more conservative approach and only cherry
> > picked the changes necessary to address the Venezuelan Bolivar, which
> > is the subject of the bug, and did not update the whole ISO 4217 file:
> >
> > http://cr.openjdk.java.net/~neugens/8208746/webrev/jdk.changeset
> >
> > The original patch is here:
> >
> > http://hg.openjdk.java.net/jdk/jdk/rev/67092c6be8e1
> >
> > If approved, I will have shortly a followup backport request for a
> > related issue:
> >
> > https://bugs.openjdk.java.net/browse/JDK-8210153
> >
> > Cheers,
> > Mario
> >
>
> This patch seems to include all the data changes, but without altering
> dataVersion, so we end up with a file labelled with a version of #162,
> but with data from update #168 & #169.
>
> This is just creating potential confusion for future updates. Please
> backport JDK-8187946 & JDK-8193552 first so the files accurately reflect
> #169.
>
> Thanks,
> --
> Andrew :)
>
> Senior Free Java Software Engineer
> Red Hat, Inc. (http://www.redhat.com)
>
> PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
> Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222
> https://keybase.io/gnu_andrew
>
--
Mario Torre
Associate Manager, Software Engineering
Red Hat GmbH <https://www.redhat.com>
9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898
More information about the jdk8u-dev
mailing list