RFC: backport of JDK-8209775: ISO 4217 Amendment #169 Update

[Andrew John Hughes]

On 24/06/2019 16:00, Mario Torre wrote:
> On Mon, Jun 24, 2019 at 4:44 PM Andrew John Hughes
> <gnu.andrew at redhat.com> wrote:
>>
>>
>>
>> On 24/06/2019 14:41, Mario Torre wrote:
>>> Hi Andrew and all,
>>>
>>> This is the second attempt.
>>>
>>> I backported together the related issues:
>>>
>>> https://bugs.openjdk.java.net/browse/JDK-8187946
>>> https://bugs.openjdk.java.net/browse/JDK-8193552
>>> https://bugs.openjdk.java.net/browse/JDK-8209775
>>>
>>> The changes apply almost cleanly, with some minor tweak, here's the
>>> cumulative webrev:
>>>
>>> http://cr.openjdk.java.net/~neugens/8209775-backport/webrev.00/
>>>
>>> Here are the single backported patches if this is a bit easier to read:
>>>
>>> http://cr.openjdk.java.net/~neugens/8209775-backport/webrev.00/8209775.patch
>>> http://cr.openjdk.java.net/~neugens/8209775-backport/webrev.00/8193552.patch
>>> http://cr.openjdk.java.net/~neugens/8209775-backport/webrev.00/8187946.patch
>>>
>>> They apply in this order 8187946.patch, 8193552.patch, 8209775.patch.
>>>
>>> The only thing missing is the change from version 2 to version 3 of
>>> the CurrencyData.properties file format, this is done in
>>> https://bugs.openjdk.java.net/browse/JDK-7102969 but I didn't backport
>>> this in this current batch, I think we should consider if we want to
>>> backport this too in the future.
>>>
>>> Cheers,
>>> Mario
>>>
>>
>> To keep things simple, let's do one at a time.
> 
> Sure, do you want me to send separate RFC emails for each patch?
> 

No, this is fine. It just gets tricky trying to apply them on top of
each other, so better to deal with one, let you push it, and then look
at the next applied against the new base.

Incidentally, these have jdk8u-critical-yes so can go to
https://hg.openjdk.java.net//jdk8u/jdk8u/jdk rather than jdk8u-dev.

>> For 8187946, the patch looks the same as what I have and looks good to push.
>>
>> test/java/util/Currency/ValidateISO4217.java passes.
>> test/sun/text/resources/LocaleDataTest.java has one failure which can be
>> resolved by following up with JDK-8195478 (there's now a duplicate
>> CurrencyNames//azn).
> 
> Yes, I realised this, I was about to send a call for this too.

Thanks.

> 
> Cheers,
> Mario
> 

-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew