[8u] Re-examine closed i18n tests to see it they can be moved to the jdk repository

[Hohensee, Paul]

I'm ok with it: more tests are a good thing.

Thanks,

Paul

On 6/28/19, 1:31 PM, "jdk8u-dev on behalf of Andrew John Hughes" <jdk8u-dev-bounces at openjdk.java.net on behalf of gnu.andrew at redhat.com> wrote:

    Bug: https://bugs.openjdk.java.net/browse/JDK-8031145 (not accessible)
    Webrev: https://cr.openjdk.java.net/~andrew/openjdk8/8031145/webrev.01/
    
    This changeset adds a slew of tests for outputting internationalised
    data. This is a pre-requisite for "8210153: localized currency symbol of
    VES" which updates the CurrencyFormat.java test added by this set.
    
    For such a large set, the number of failures is quite small:
    
    FAILED: java/util/TimeZone/HongKong.java
    FAILED: java/util/Calendar/CalendarRegression.java
    FAILED: sun/text/IntHashtable/Bug4170614Test.sh
    FAILED: java/text/BreakIterator/BreakIteratorTest.java
    FAILED: java/text/Format/DateFormat/DateFormatTest.java
    FAILED: java/text/Format/DateFormat/NonGregorianFormatTest.java
    FAILED: java/text/Format/MessageFormat/LargeMessageFormat.java
    FAILED: java/text/Format/NumberFormat/NumberRegression.java
    FAILED: java/text/Format/NumberFormat/NumberTest.java
    
    Most of these appear to be down to outdated locale data, as also
    mentioned in my RFR for JDK-8218781 [0] (e.g. the HongKong failure is
    due to the HK locale returning English values). JDK-7094818 also looks
    like a potential backport candidate.
    
    Other than minor context changes in TEST.groups (the only file modified
    rather than added), a fix to test/java/text/testlib/HexDumpReader.java
    was required as Java 8 does not have Integer.parseInt(CharSequence s,
    int begin, int end, int radix). This is easily replaced by supplying the
    substring as the original argument:
    
    -+                    bab.put((byte)Integer.parseInt(line, i, i + 2, 16));
    ++                    bab.put((byte)Integer.parseInt(line.substring(i, i
    + 2), 16));
    
    I also included changes from the 11u version of JDK-8151876, which
    weren't part of the version in 8u because these tests were absent. This
    includes the removal of test/java/util/TimeZone/CheckDisplayNames.java,
    and adding 8151876 to the bug ID list of
    test/java/util/TimeZone/TimeZoneTest.java.
    
    Ok for 8u?
    
    This was also need critical approval here, as I can't tag the bug itself.
    
    [0] https://mail.openjdk.java.net/pipermail/jdk8u-dev/2019-June/009667.html
    -- 
    Andrew :)
    
    Senior Free Java Software Engineer
    Red Hat, Inc. (http://www.redhat.com)
    
    PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
    Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
    https://keybase.io/gnu_andrew