[8u] RFR: 8210761: libjsig is being compiled without optimization

[Thomas Stüfe]

I'd be okay with doing this on AIX if Christoph is.

One curious question though about the original bug, was this really a
measurable performance issue? I would have thought that libjsig is not
invoked often enough for this to make a difference..

Cheers, Thomas



On Wed, Jun 26, 2019 at 2:05 PM Andrew John Hughes <gnu.andrew at redhat.com>
wrote:

>
>
> On 25/06/2019 10:04, Severin Gehwolf wrote:
> > Hi,
> >
> > Could somebody please review this 8u backport? The build system in 8 is
> > different, especially hotspot makefiles. Note, libjsig.so is part of
> > the hotspot build. The patch is different in 8 (over 11) due to this
> > reason. This is a Linux-only change and should be low risk. Thoughts?
> >
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8210761
> > webrev:
> http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8210761/jdk8/01/webrev/
> >
> > Change in JDK 11:
> http://hg.openjdk.java.net/jdk-updates/jdk11u/rev/e7aa96dc0b1e
> >
> > Testing: Manual build of slowdebug/fastdebug/release on x86_64.
> > Fastdebug/release builds receive the -O3 flag, slowdebug not. As
> > expected.
> >
> > Thanks,
> > Severin
> >
>
> The 11u fix applies to all 'unix' platforms, as far as I can see. Should
> the 8u equivalent not also be applied to the solaris, bsd and aix
> subdirectories as well for consistency?
>
> Thanks,
> --
> Andrew :)
>
> Senior Free Java Software Engineer
> Red Hat, Inc. (http://www.redhat.com)
>
> PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
> Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
> https://keybase.io/gnu_andrew
>
>